]> Gentwo Git Trees - linux/.git/commit
media: i2c: imx214: Rearrange control initialization
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 20 Oct 2025 20:18:13 +0000 (20:18 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Thu, 13 Nov 2025 09:57:52 +0000 (10:57 +0100)
commit15ac3d54a8296e027bf176115e36c3cb8c55c8cc
tree6097274066414be686b6be1de2d4291053c10c86
parente687f5cae591dba4a0a968c24cbe7b6141027d93
media: i2c: imx214: Rearrange control initialization

Smatch is confused by the control initialization logic. It assumes that
there can be a case where imx214->link_freq can be NULL and ctrls_init
returns 0.

Re-arrange the function to make smatch happy.

This patch fixes this smatch error:
drivers/media/i2c/imx214.c:1109 imx214_ctrls_init() error: we previously assumed 'imx214->link_freq' could be null (see line 1017)

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/imx214.c