]> Gentwo Git Trees - linux/.git/commit
afs: Fix uninit var in afs_alloc_anon_key()
authorDavid Howells <dhowells@redhat.com>
Sat, 29 Nov 2025 00:40:11 +0000 (00:40 +0000)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sat, 29 Nov 2025 00:48:18 +0000 (16:48 -0800)
commit19eef1d98eeda3745df35839190b7d4a4adea656
tree8d0b29825fa335ad0b98a8fc9e09d34d87d5e96b
parente6640487845061255af9614ec0a192e4fafa486e
afs: Fix uninit var in afs_alloc_anon_key()

Fix an uninitialised variable (key) in afs_alloc_anon_key() by setting it
to cell->anonymous_key.  Without this change, the error check may return a
false failure with a bad error number.

Most of the time this is unlikely to happen because the first encounter
with afs_alloc_anon_key() will usually be from (auto)mount, for which all
subsequent operations must wait - apart from other (auto)mounts.  Once the
call->anonymous_key is allocated, all further calls to afs_request_key()
will skip the call to afs_alloc_anon_key() for that cell.

Fixes: d27c71257825 ("afs: Fix delayed allocation of a cell's anonymous key")
Reported-by: Paulo Alcantra <pc@manguebit.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Paulo Alcantara <pc@manguebit.org>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: syzbot+41c68824eefb67cdf00c@syzkaller.appspotmail.com
cc: linux-afs@lists.infradead.org
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/afs/security.c