]> Gentwo Git Trees - linux/.git/commit
usb: cdns3: Fix double resource release in cdns3_pci_probe
authorMiaoqian Lin <linmq006@gmail.com>
Sun, 26 Oct 2025 09:08:59 +0000 (17:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Oct 2025 14:46:16 +0000 (15:46 +0100)
commit1ec39d2cd88dac2e7cdbac248762f1f057971c5d
tree657f7974233735173cac84aa677cca8377f8f403
parentbaeb66fbd4201d1c4325074e78b1f557dff89b5b
usb: cdns3: Fix double resource release in cdns3_pci_probe

The driver uses pcim_enable_device() to enable the PCI device,
the device will be automatically disabled on driver detach through
the managed device framework. The manual pci_disable_device() calls
in the error paths are therefore redundant and should be removed.

Found via static anlaysis and this is similar to commit 99ca0b57e49f
("thermal: intel: int340x: processor: Fix warning during module unload").

Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
Cc: stable <stable@kernel.org>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Acked-by: Peter Chen <peter.chen@kernel.org>
Link: https://patch.msgid.link/20251026090859.33107-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/cdns3-pci-wrap.c