]> Gentwo Git Trees - linux/.git/commit
NFSv4: Fix an incorrect parameter when calling nfs4_call_sync()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Fri, 31 Oct 2025 14:51:42 +0000 (10:51 -0400)
committerAnna Schumaker <anna.schumaker@oracle.com>
Mon, 10 Nov 2025 19:30:46 +0000 (14:30 -0500)
commit1f214e9c3aef2d0936be971072e991d78a174d71
tree7658faa9513178b23664cb0de307b17024d0b5c6
parent7a7a3456520b309a0bffa1d9d62bd6c9dcab89b3
NFSv4: Fix an incorrect parameter when calling nfs4_call_sync()

The Smatch static checker noted that in _nfs4_proc_lookupp(), the flag
RPC_TASK_TIMEOUT is being passed as an argument to nfs4_init_sequence(),
which is clearly incorrect.
Since LOOKUPP is an idempotent operation, nfs4_init_sequence() should
not ask the server to cache the result. The RPC_TASK_TIMEOUT flag needs
to be passed down to the RPC layer.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Reported-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Fixes: 76998ebb9158 ("NFSv4: Observe the NFS_MOUNT_SOFTREVAL flag in _nfs4_proc_lookupp")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
fs/nfs/nfs4proc.c