]> Gentwo Git Trees - linux/.git/commit
crypto: skcipher - Fix reqsize handling
authorT Pratham <t-pratham@ti.com>
Tue, 7 Oct 2025 13:57:51 +0000 (19:27 +0530)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 8 Oct 2025 08:13:07 +0000 (16:13 +0800)
commit229c586b5e86979badb7cb0d38717b88a9e95ddd
tree0dc4fd8c108d24bdbf7681713c3865ae6148b8af
parentc0d36727bf39bb16ef0a67ed608e279535ebf0da
crypto: skcipher - Fix reqsize handling

Commit afddce13ce81d ("crypto: api - Add reqsize to crypto_alg")
introduced cra_reqsize field in crypto_alg struct to replace type
specific reqsize fields. It looks like this was introduced specifically
for ahash and acomp from the commit description as subsequent commits
add necessary changes in these alg frameworks.

However, this is being recommended for use in all crypto algs [1]
instead of setting reqsize using crypto_*_set_reqsize(). Using
cra_reqsize in skcipher algorithms, hence, causes memory
corruptions and crashes as the underlying functions in the algorithm
framework have not been updated to set the reqsize properly from
cra_reqsize. [2]

Add proper set_reqsize calls in the skcipher init function to
properly initialize reqsize for these algorithms in the framework.

[1]: https://lore.kernel.org/linux-crypto/aCL8BxpHr5OpT04k@gondor.apana.org.au/
[2]: https://gist.github.com/Pratham-T/24247446f1faf4b7843e4014d5089f6b

Fixes: afddce13ce81d ("crypto: api - Add reqsize to crypto_alg")
Fixes: 52f641bc63a4 ("crypto: ti - Add driver for DTHE V2 AES Engine (ECB, CBC)")
Signed-off-by: T Pratham <t-pratham@ti.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/skcipher.c