]> Gentwo Git Trees - linux/.git/commit
remoteproc: k3: Correctly release some resources allocated in k3_rproc_request_mbox()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 24 Aug 2025 19:52:37 +0000 (21:52 +0200)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Fri, 29 Aug 2025 16:09:52 +0000 (10:09 -0600)
commit2433961962be8b8ff32058763339b818128e8ff0
tree7af24ab929f79ade25ec510e1f0210d8ffd94fc2
parent3df0bee9c5b94ca9e3e2ff0f4c4e9886eac86055
remoteproc: k3: Correctly release some resources allocated in k3_rproc_request_mbox()

If an error occurs after a successful k3_rproc_request_mbox() call,
mbox_free_channel() should be called to avoid a leak.

Such a call is missing in the error handling path of k3_dsp_rproc_probe().
It is also missing both in the error handling path of k3_m4_rproc_probe()
and in the (in-existent) corresponding remove function.

Switch to managed resources to avoid these leaks and simplify the code.
Remove the now unneeded mbox_free_channel().

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Beleswar Padhi <b-padhi@ti.com>
Tested-by: Beleswar Padhi <b-padhi@ti.com>
Link: https://lore.kernel.org/r/df853ede72e9972c464415990b196289680e6acb.1756065142.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/ti_k3_common.c
drivers/remoteproc/ti_k3_dsp_remoteproc.c
drivers/remoteproc/ti_k3_r5_remoteproc.c