]> Gentwo Git Trees - linux/.git/commit
drm/msm: fix missing NULL check after kcalloc in crashstate_get_bos()
authorHuiwen He <hehuiwen@kylinos.cn>
Wed, 12 Nov 2025 17:19:47 +0000 (01:19 +0800)
committerRob Clark <rob.clark@oss.qualcomm.com>
Mon, 17 Nov 2025 17:43:58 +0000 (09:43 -0800)
commit3065e6a4d3594b42dae6176b3e2c0c3563cf94b8
treee4e9cd12b6e65f0e0c35bbd32772f8f945194ece
parent3099e0247e3217e1b39c1c61766e06ec3d13835f
drm/msm: fix missing NULL check after kcalloc in crashstate_get_bos()

The crashstate_get_bos() function allocates memory for `state->bos`
using kcalloc(), but the vmbind path does not check for allocation
failure before dereferencing it in the following drm_gpuvm_for_each_va()
loop. This could lead to a NULL pointer dereference if memory allocation
fails.

Fix this by wrapping the drm_gpuvm_for_each_va() loop with a NULL check
on state->bos, similar to the safety check in the non-vmbind path.

Fixes: af9aa6f316b3d ("drm/msm: Crashdump support for sparse")
Signed-off-by: Huiwen He <hehuiwen@kylinos.cn>
Patchwork: https://patchwork.freedesktop.org/patch/687556/
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
drivers/gpu/drm/msm/msm_gpu.c