]> Gentwo Git Trees - linux/.git/commit
selftests: drv-net: Set shell=True for sysfs writes in devlink_rate_tc_bw.py
authorCarolina Jubran <cjubran@nvidia.com>
Sun, 30 Nov 2025 09:19:36 +0000 (11:19 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 2 Dec 2025 01:18:41 +0000 (17:18 -0800)
commit3796e549e305194ac379c843f0eec5e013276fc3
treec9a38e8453e806712ed93ec7ed93f842a91e5732
parentcb1acbd30a42204b39e4846e1139b6fa9a40fafe
selftests: drv-net: Set shell=True for sysfs writes in devlink_rate_tc_bw.py

Commit 7c32f7a2d3db ("selftests: net: py: don't default to shell=True")
changed the cmd() helper to avoid spawning a shell unless explicitly
requested.

The devlink_rate_tc_bw test enables SR-IOV by writing to the
sriov_numvfs sysfs attribute using redirection. Without shell=True the
redirection is not interpreted and the VF device never appears,
causing the test to fail.

Fix by explicitly passing shell=True in the two places that update
sriov_numvfs.

Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Nimrod Oren <noren@nvidia.com>
Link: https://patch.msgid.link/20251130091938.4109055-5-cjubran@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/drivers/net/hw/devlink_rate_tc_bw.py