]> Gentwo Git Trees - linux/.git/commit
6pack: drop redundant locking and refcounting
authorQingfang Deng <dqfext@gmail.com>
Thu, 25 Sep 2025 05:10:59 +0000 (13:10 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 30 Sep 2025 08:10:59 +0000 (10:10 +0200)
commit38b04ed7072e54086102eae2d05d03ffcdb4b695
treea03a601c2a8d8c446ab30e3757a2437bda6aab12
parent7bd80ed89d72285515db673803b021469ba71ee8
6pack: drop redundant locking and refcounting

The TTY layer already serializes line discipline operations with
tty->ldisc_sem, so the extra disc_data_lock and refcnt in 6pack
are unnecessary.

Removing them simplifies the code and also resolves a lockdep warning
reported by syzbot. The warning did not indicate a real deadlock, since
the write-side lock was only taken in process context with hardirqs
disabled.

Reported-by: syzbot+5fd749c74105b0e1b302@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/68c858b0.050a0220.3c6139.0d1c.GAE@google.com/
Signed-off-by: Qingfang Deng <dqfext@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/20250925051059.26876-1-dqfext@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/hamradio/6pack.c