]> Gentwo Git Trees - linux/.git/commit
drm/xe/configfs: Enforce canonical device names
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Tue, 22 Jul 2025 14:10:55 +0000 (16:10 +0200)
committerLucas De Marchi <lucas.demarchi@intel.com>
Fri, 25 Jul 2025 12:59:07 +0000 (05:59 -0700)
commit400a6da1e967c4f117e4757412df06dcfaea0e6a
tree35c7cc0078f4d11330303ecaff26b49912f55666
parent0bdd05c2a82bbf2419415d012fd4f5faeca7f1af
drm/xe/configfs: Enforce canonical device names

While we expect config directory names to match PCI device name,
currently we are only scanning provided names for domain, bus,
device and function numbers, without checking their format.
This would pass slightly broken entries like:

  /sys/kernel/config/xe/
  ├── 0000:00:02.0000000000000
  │   └── ...
  ├── 0000:00:02.0x
  │   └── ...
  ├──  0: 0: 2. 0
  │   └── ...
  └── 0:0:2.0
      └── ...

To avoid such mistakes, check if the name provided exactly matches
the canonical PCI device address format, which we recreated from
the parsed BDF data. Also simplify scanf format as it can't really
catch all formatting errors.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20250722141059.30707-3-michal.wajdeczko@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_configfs.c