]> Gentwo Git Trees - linux/.git/commit
jbd2: use a weaker annotation in journal handling
authorByungchul Park <byungchul@sk.com>
Fri, 24 Oct 2025 07:39:40 +0000 (16:39 +0900)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 13 Nov 2025 13:43:44 +0000 (08:43 -0500)
commit40a71b53d5a6d4ea17e4d54b99b2ac03a7f5e783
tree97fb8246e81c01d5a11b5eb6263836447b06b89b
parent524c3853831cf4f7e1db579e487c757c3065165c
jbd2: use a weaker annotation in journal handling

jbd2 journal handling code doesn't want jbd2_might_wait_for_commit()
to be placed between start_this_handle() and stop_this_handle().  So it
marks the region with rwsem_acquire_read() and rwsem_release().

However, the annotation is too strong for that purpose.  We don't have
to use more than try lock annotation for that.

rwsem_acquire_read() implies:

   1. might be a waiter on contention of the lock.
   2. enter to the critical section of the lock.

All we need in here is to act 2, not 1.  So trylock version of
annotation is sufficient for that purpose.  Now that dept partially
relies on lockdep annotaions, dept interpets rwsem_acquire_read() as a
potential wait and might report a deadlock by the wait.

Replace it with trylock version of annotation.

Signed-off-by: Byungchul Park <byungchul@sk.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: stable@kernel.org
Message-ID: <20251024073940.1063-1-byungchul@sk.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/transaction.c