]> Gentwo Git Trees - linux/.git/commit
drm/imagination: take paired job reference
authorBrendan King <Brendan.King@imgtec.com>
Tue, 18 Mar 2025 14:53:13 +0000 (14:53 +0000)
committerMatt Coster <matt.coster@imgtec.com>
Tue, 25 Mar 2025 17:17:37 +0000 (17:17 +0000)
commit4ba2abe154ef68f9612eee9d6fbfe53a1736b064
tree43996da51059e9da75d074646de3f1f8a717b337
parent021ba7f1babd029e714d13a6bf2571b08af96d0f
drm/imagination: take paired job reference

For paired jobs, have the fragment job take a reference on the
geometry job, so that the geometry job cannot be freed until
the fragment job has finished with it.

The geometry job structure is accessed when the fragment job is being
prepared by the GPU scheduler. Taking the reference prevents the
geometry job being freed until the fragment job no longer requires it.

Fixes a use after free bug detected by KASAN:

[  124.256386] BUG: KASAN: slab-use-after-free in pvr_queue_prepare_job+0x108/0x868 [powervr]
[  124.264893] Read of size 1 at addr ffff0000084cb960 by task kworker/u16:4/63

Cc: stable@vger.kernel.org
Fixes: eaf01ee5ba28 ("drm/imagination: Implement job submission and scheduling")
Signed-off-by: Brendan King <brendan.king@imgtec.com>
Reviewed-by: Matt Coster <matt.coster@imgtec.com>
Link: https://lore.kernel.org/r/20250318-ddkopsrc-1337-use-after-free-in-pvr_queue_prepare_job-v1-1-80fb30d044a6@imgtec.com
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
drivers/gpu/drm/imagination/pvr_job.c
drivers/gpu/drm/imagination/pvr_queue.c