]> Gentwo Git Trees - linux/.git/commit
iommu/mediatek: simplify dt parsing error handling
authorJohan Hovold <johan@kernel.org>
Mon, 20 Oct 2025 04:53:11 +0000 (06:53 +0200)
committerJoerg Roedel <joerg.roedel@amd.com>
Mon, 17 Nov 2025 08:49:43 +0000 (09:49 +0100)
commit4f2a4aec1cf6f89743cf7acaac6c62eb2f21120b
tree4c1155cd11741d3f991050e0a630ccb02587d288
parentde83d4617f9fe059623e97acf7e1e10d209625b5
iommu/mediatek: simplify dt parsing error handling

As previously documented by commit 26593928564c ("iommu/mediatek: Add
error path for loop of mm_dts_parse"), the id mapping may not be linear
so the whole larb array needs to be iterated on devicetree parsing
errors.

Simplify the loop by iterating from index zero while dropping the
redundant NULL check for consistency with later cleanups.

Also add back the comment which was removed by commit 462e768b55a2
("iommu/mediatek: Fix forever loop in error handling") to prevent anyone
from trying to optimise the loop by iterating backwards from 'i'.

Cc: Yong Wu <yong.wu@mediatek.com>
Acked-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
drivers/iommu/mtk_iommu.c