]> Gentwo Git Trees - linux/.git/commit
serial: 8250: document doubled "type == PORT_8250_CIR" check
authorJiri Slaby (SUSE) <jirislaby@kernel.org>
Tue, 24 Jun 2025 08:06:40 +0000 (10:06 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Jun 2025 14:32:56 +0000 (15:32 +0100)
commit543a5af343402d007689f2ec8cfc11670b368b8c
tree9705c92aa25779b455ea65f2ab93bc9d6942d903
parent2721fc7adc923fb8d6ff55028e3e460ed93c1cb5
serial: 8250: document doubled "type == PORT_8250_CIR" check

The check for "port.type == PORT_8250_CIR" is present twice in
serial8250_register_8250_port(). The latter was already tried to be
dropped by 1104321a7b3b ("serial: Delete dead code for CIR serial
ports") and then reverted by 9527b82ae3af ("Revert "serial: Delete dead
code for CIR serial ports"").

Document this weirdness with a reason.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Link: https://lore.kernel.org/all/aFcDOx1bdB34I5hS@surfacebook.localdomain/
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20250624080641.509959-5-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_core.c