]> Gentwo Git Trees - linux/.git/commit
btrfs: abort transaction on item count overflow in __push_leaf_left()
authorFilipe Manana <fdmanana@suse.com>
Thu, 13 Nov 2025 16:44:41 +0000 (16:44 +0000)
committerDavid Sterba <dsterba@suse.com>
Mon, 24 Nov 2025 21:42:25 +0000 (22:42 +0100)
commit5d8222a50ad37c98455da08b33ce49fe6b726c72
tree83c32cac76b39946459d4c73bdc1606e05c03fdd
parent027358a0900913a395f99d911108375a7f1c50f4
btrfs: abort transaction on item count overflow in __push_leaf_left()

If we try to push an item count from the right leaf that is greater than
the number of items in the leaf, we just emit a warning. This should
never happen but if it does we get an underflow in the new number of
items in the right leaf and chaos follows from it. So replace the warning
with proper error handling, by aborting the transaction and returning
-EUCLEAN, and proper logging by using btrfs_crit() instead of WARN(),
which gives us proper formatting and information about the filesystem.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ctree.c