]> Gentwo Git Trees - linux/.git/commit
regulator: fixed: fix GPIO descriptor leak on register failure
authorHaotian Zhang <vulab@iscas.ac.cn>
Tue, 28 Oct 2025 17:28:28 +0000 (01:28 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 5 Nov 2025 11:56:16 +0000 (11:56 +0000)
commit636f4618b1cd96f6b5a2b8c7c4f665c8533ecf13
treede4b9667131356a03f5f8edb5469345f66440d4d
parent6146a0f1dfae5d37442a9ddcba012add260bceb0
regulator: fixed: fix GPIO descriptor leak on register failure

In the commit referenced by the Fixes tag,
devm_gpiod_get_optional() was replaced by manual
GPIO management, relying on the regulator core to release the
GPIO descriptor. However, this approach does not account for the
error path: when regulator registration fails, the core never
takes over the GPIO, resulting in a resource leak.

Add gpiod_put() before returning on regulator registration failure.

Fixes: 5e6f3ae5c13b ("regulator: fixed: Let core handle GPIO descriptor")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
Link: https://patch.msgid.link/20251028172828.625-1-vulab@iscas.ac.cn
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/fixed.c