]> Gentwo Git Trees - linux/.git/commit
Revert "net: group sk_backlog and sk_receive_queue"
authorEric Dumazet <edumazet@google.com>
Mon, 29 Sep 2025 18:21:12 +0000 (18:21 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 30 Sep 2025 01:30:32 +0000 (18:30 -0700)
commit7d452516b67add4a53e63bfa496d8df930a66b9a
tree65f4c308736bf41a525ef550250d33ad4bf66d0c
parent9dd4e022bfffe0fbc6eaccdb52fc25554be5c367
Revert "net: group sk_backlog and sk_receive_queue"

This reverts commit 4effb335b5dab08cb6e2c38d038910f8b527cfc9.

This was a benefit for UDP flood case, which was later greatly improved
with commits 6471658dc66c ("udp: use skb_attempt_defer_free()")
and b650bf0977d3 ("udp: remove busylock and add per NUMA queues").

Apparently blamed commit added a regression for RAW sockets, possibly
because they do not use the dual RX queue strategy that UDP has.

sock_queue_rcv_skb_reason() and RAW recvmsg() compete for sk_receive_buf
and sk_rmem_alloc changes, and them being in the same
cache line reduce performance.

Fixes: 4effb335b5da ("net: group sk_backlog and sk_receive_queue")
Reported-by: kernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202509281326.f605b4eb-lkp@intel.com
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Cc: David Ahern <dsahern@kernel.org>
Cc: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20250929182112.824154-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/sock.h