]> Gentwo Git Trees - linux/.git/commit
spi: cadence-quadspi: Fix pm_runtime unbalance on dma EPROBE_DEFER
authorMattijs Korpershoek <mkorpershoek@kernel.org>
Thu, 9 Oct 2025 07:10:38 +0000 (09:10 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 13 Oct 2025 12:34:08 +0000 (13:34 +0100)
commit8735696acea24ac1f9d4490992418c71941ca68c
tree6b6b8d43be2a7e58753163d0db9341146d3d99f5
parent4f38da1f027ea2c9f01bb71daa7a299c191b6940
spi: cadence-quadspi: Fix pm_runtime unbalance on dma EPROBE_DEFER

In csqspi_probe(), when cqspi_request_mmap_dma() returns -EPROBE_DEFER,
we handle the error by jumping to probe_setup_failed.
In that label, we call pm_runtime_disable(), even if we never called
pm_runtime_enable() before.

Because of this, the driver cannot probe:

[    2.690018] cadence-qspi 47040000.spi: No Rx DMA available
[    2.699735] spi-nor spi0.0: resume failed with -13
[    2.699741] spi-nor: probe of spi0.0 failed with error -13

Only call pm_runtime_disable() if it was enabled by adding a new
label to handle cqspi_request_mmap_dma() failures.

Fixes: b07f349d1864 ("spi: spi-cadence-quadspi: Fix pm runtime unbalance")
Signed-off-by: Mattijs Korpershoek <mkorpershoek@kernel.org>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/20251009-cadence-quadspi-fix-pm-runtime-v2-1-8bdfefc43902@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c