]> Gentwo Git Trees - linux/.git/commit
ALSA: hda/tas2781: fix speaker id retrieval for multiple probes
authorAntheas Kapenekakis <lkml@antheas.dev>
Sun, 26 Oct 2025 19:16:34 +0000 (20:16 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 18 Nov 2025 06:52:55 +0000 (07:52 +0100)
commit945865a0ddf3e3950aea32e23e10d815ee9b21bc
tree033aae25099e5785c02b71fd033d046c0ec15247
parent9c3af1b2f73cc72f5035bc9372c18b3780e1f258
ALSA: hda/tas2781: fix speaker id retrieval for multiple probes

Currently, on ASUS projects, the TAS2781 codec attaches the speaker GPIO
to the first tasdevice_priv instance using devm. This causes
tas2781_read_acpi to fail on subsequent probes since the GPIO is already
managed by the first device. This causes a failure on Xbox Ally X,
because it has two amplifiers, and prevents us from quirking both the
Xbox Ally and Xbox Ally X in the realtek codec driver.

It is unnecessary to attach the GPIO to a device as it is static.
Therefore, instead of attaching it and then reading it when loading the
firmware, read its value directly in tas2781_read_acpi and store it in
the private data structure. Then, make reading the value non-fatal so
that ASUS projects that miss a speaker pin can still work, perhaps using
fallback firmware.

Fixes: 4e7035a75da9 ("ALSA: hda/tas2781: Add speaker id check for ASUS projects")
Cc: stable@vger.kernel.org # 6.17
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
Reviewed-by: Baojun Xu <baojun.xu@ti.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20251026191635.2447593-1-lkml@antheas.dev
include/sound/tas2781.h
sound/hda/codecs/side-codecs/tas2781_hda_i2c.c