]> Gentwo Git Trees - linux/.git/commit
btrfs: tree-checker: fix the incorrect inode ref size check
authorQu Wenruo <wqu@suse.com>
Mon, 15 Sep 2025 22:24:06 +0000 (07:54 +0930)
committerDavid Sterba <dsterba@suse.com>
Thu, 18 Sep 2025 03:47:25 +0000 (05:47 +0200)
commit96fa515e70f3e4b98685ef8cac9d737fc62f10e1
treec99c29e4626afdf0f44d2aece53bf97c81bbf7bd
parent80eb65ccf6f72dc37b972583fe71cd8a50ff7e51
btrfs: tree-checker: fix the incorrect inode ref size check

[BUG]
Inside check_inode_ref(), we need to make sure every structure,
including the btrfs_inode_extref header, is covered by the item.  But
our code is incorrectly using "sizeof(iref)", where @iref is just a
pointer.

This means "sizeof(iref)" will always be "sizeof(void *)", which is much
smaller than "sizeof(struct btrfs_inode_extref)".

This will allow some bad inode extrefs to sneak in, defeating tree-checker.

[FIX]
Fix the typo by calling "sizeof(*iref)", which is the same as
"sizeof(struct btrfs_inode_extref)", and will be the correct behavior we
want.

Fixes: 71bf92a9b877 ("btrfs: tree-checker: Add check for INODE_REF")
CC: stable@vger.kernel.org # 6.1+
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tree-checker.c