]> Gentwo Git Trees - linux/.git/commit
spi: spi-fsl-lpspi: fix watermark truncation caused by type cast
authorCarlos Song <carlos.song@nxp.com>
Mon, 17 Nov 2025 03:03:55 +0000 (11:03 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 21 Nov 2025 14:23:45 +0000 (14:23 +0000)
commit9f0c21bac5a8089e74b21d007e26fb4594b10d73
tree0d1eea37deaaf16349d76d02c189d719fd27eead
parent295fe8406a357bc0abb901a21d1a554fd4dd1d05
spi: spi-fsl-lpspi: fix watermark truncation caused by type cast

't->len' is an unsigned integer, while 'watermark' and 'txfifosize' are
u8. Using min_t with typeof(watermark) forces both values to be cast to
u8, which truncates len when it exceeds 255. For example, len = 4096
becomes 0 after casting, resulting in an incorrect watermark value.

Use a wider type in min_t to avoid truncation and ensure the correct
minimum value is applied.

Fixes: a750050349ea ("spi: spi-fsl-lpspi: use min_t() to improve code")
Signed-off-by: Carlos Song <carlos.song@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://patch.msgid.link/20251117030355.1359081-1-carlos.song@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-lpspi.c