]> Gentwo Git Trees - linux/.git/commit
ring-buffer: Do not warn in ring_buffer_map_get_reader() when reader catches up
authorSteven Rostedt <rostedt@goodmis.org>
Thu, 16 Oct 2025 17:28:48 +0000 (13:28 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Fri, 7 Nov 2025 00:38:54 +0000 (19:38 -0500)
commitaa997d2d2a0b2e76f4df0f1f12829f02acb4fb6b
treeb390c0a10b39ca16251cd49654b5df4e1d451867
parentdcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
ring-buffer: Do not warn in ring_buffer_map_get_reader() when reader catches up

The function ring_buffer_map_get_reader() is a bit more strict than the
other get reader functions, and except for certain situations the
rb_get_reader_page() should not return NULL. If it does, it triggers a
warning.

This warning was triggering but after looking at why, it was because
another acceptable situation was happening and it wasn't checked for.

If the reader catches up to the writer and there's still data to be read
on the reader page, then the rb_get_reader_page() will return NULL as
there's no new page to get.

In this situation, the reader page should not be updated and no warning
should trigger.

Cc: stable@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Vincent Donnefort <vdonnefort@google.com>
Reported-by: syzbot+92a3745cea5ec6360309@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/all/690babec.050a0220.baf87.0064.GAE@google.com/
Link: https://lore.kernel.org/20251016132848.1b11bb37@gandalf.local.home
Fixes: 117c39200d9d7 ("ring-buffer: Introducing ring-buffer mapping functions")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/ring_buffer.c