]> Gentwo Git Trees - linux/.git/commit
nfsd: delete unreachable confusing code in nfs4_open_delegation()
authorMatvey Kovalev <matvey.kovalev@ispras.ru>
Mon, 29 Sep 2025 17:35:20 +0000 (20:35 +0300)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 16 Nov 2025 23:20:11 +0000 (18:20 -0500)
commitbfce8e4273d81a1d056ed3d79a27e1b2c4f60759
tree6cae04c510c4b01c61075030aa77691996202800
parentccd608e29b7a73b7bee45b06bfeef088a97c4c92
nfsd: delete unreachable confusing code in nfs4_open_delegation()

op_delegate_type is assigned OPEN_DELEGATE_NONE just before the if-block
where condition specifies it not be equal to OPEN_DELEGATE_NONE. Compiler
treats the block as unreachable and optimizes it out from the resulting
executable.

In that aspect commit d08d32e6e5c0 ("nfsd4: return delegation immediately
if lease fails") notably makes no difference.

Seems it's better to just drop this code instead of fiddling with memory
barriers or atomics.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Matvey Kovalev <matvey.kovalev@ispras.ru>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4state.c