]> Gentwo Git Trees - linux/.git/commit
hfs: fix potential use after free in hfs_correct_next_unused_CNID()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 3 Oct 2025 09:30:43 +0000 (12:30 +0300)
committerViacheslav Dubeyko <slava@dubeyko.com>
Thu, 6 Nov 2025 19:07:16 +0000 (11:07 -0800)
commitc105e76bb17cf4b55fe89c6ad4f6a0e3972b5b08
tree2288312b163a8e705aa0af578e1b25b24807ef6d
parent3a8660878839faadb4f1a6dd72c3179c1df56787
hfs: fix potential use after free in hfs_correct_next_unused_CNID()

This code calls hfs_bnode_put(node) which drops the refcount and then
dreferences "node" on the next line.  It's only safe to use "node"
when we're holding a reference so flip these two lines around.

Fixes: a06ec283e125 ("hfs: add logic of correcting a next unused CNID")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Viacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
Link: https://lore.kernel.org/r/aN-Xw8KnbSnuIcLk@stanley.mountain
Signed-off-by: Viacheslav Dubeyko <slava@dubeyko.com>
fs/hfs/catalog.c