]> Gentwo Git Trees - linux/.git/commit
iavf: fix proper type for error code in iavf_resume()
authorAleksandr Loktionov <aleksandr.loktionov@intel.com>
Fri, 12 Sep 2025 08:02:08 +0000 (08:02 +0000)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 19 Sep 2025 15:42:08 +0000 (08:42 -0700)
commitc4f7a6672f9019c9509c656c76dcbe804fb66e0c
treeb00dfcc924e4bbe62b5d30c52c514934b18bce3e
parent7a5a03869801e2f1cabdc55b2e697fea20da5c68
iavf: fix proper type for error code in iavf_resume()

The variable 'err' in iavf_resume() is used to store the return value
of different functions, which return an int. Currently, 'err' is
declared as u32, which is semantically incorrect and misleading.

In the Linux kernel, u32 is typically reserved for fixed-width data
used in hardware interfaces or protocol structures. Using it for a
generic error code may confuse reviewers or developers into thinking
the value is hardware-related or size-constrained.

Replace u32 with int to reflect the actual usage and improve code
clarity and semantic correctness.

No functional change.

Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/iavf/iavf_main.c