]> Gentwo Git Trees - linux/.git/commit
tracing: Fix irqoff tracers on failure of acquiring calltime
authorSteven Rostedt <rostedt@goodmis.org>
Wed, 8 Oct 2025 15:49:43 +0000 (11:49 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 8 Oct 2025 16:10:44 +0000 (12:10 -0400)
commitc834a97962c708ff5bb8582ca76b0e1225feb675
tree9f83abd490815f5ebc9152e3db680692221a41e4
parent4f7bf54b07e5acf79edd58dafede4096854776cd
tracing: Fix irqoff tracers on failure of acquiring calltime

The functions irqsoff_graph_entry() and irqsoff_graph_return() both call
func_prolog_dec() that will test if the data->disable is already set and
if not, increment it and return. If it was set, it returns false and the
caller exits.

The caller of this function must decrement the disable counter, but misses
doing so if the calltime fails to be acquired.

Instead of exiting out when calltime is NULL, change the logic to do the
work if it is not NULL and still do the clean up at the end of the
function if it is NULL.

Cc: stable@vger.kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/20251008114943.6f60f30f@gandalf.local.home
Fixes: a485ea9e3ef3 ("tracing: Fix irqsoff and wakeup latency tracers when using function graph")
Reported-by: Sasha Levin <sashal@kernel.org>
Closes: https://lore.kernel.org/linux-trace-kernel/20251006175848.1906912-2-sashal@kernel.org/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_irqsoff.c