]> Gentwo Git Trees - linux/.git/commit
drm/panthor: Fix memory leak in panthor_ioctl_group_create()
authorJann Horn <jannh@google.com>
Wed, 13 Nov 2024 21:03:39 +0000 (22:03 +0100)
committerSteven Price <steven.price@arm.com>
Fri, 18 Jul 2025 15:48:00 +0000 (16:48 +0100)
commitca2a6abdaee43808034cdb218428d2ed85fd3db8
tree5b22c78437f525e2fa219d775b4c73162d2d681c
parent36caa026b28a49aa91495698350ce46577293e9d
drm/panthor: Fix memory leak in panthor_ioctl_group_create()

When bailing out due to group_priority_permit() failure, the queue_args
need to be freed. Fix it by rearranging the function to use the
goto-on-error pattern, such that the success case flows straight without
indentation while error cases jump forward to cleanup.

Cc: stable@vger.kernel.org
Fixes: 5f7762042f8a ("drm/panthor: Restrict high priorities on group_create")
Signed-off-by: Jann Horn <jannh@google.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20241113-panthor-fix-gcq-bailout-v1-1-654307254d68@google.com
drivers/gpu/drm/panthor/panthor_drv.c