]> Gentwo Git Trees - linux/.git/commit
ext4: add ext4_sb_bread_nofail() helper function for ext4_free_branches()
authorBaokun Li <libaokun1@huawei.com>
Thu, 21 Aug 2025 13:38:57 +0000 (21:38 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 25 Sep 2025 18:36:54 +0000 (14:36 -0400)
commitd8b90e6387a74bcb1714c8d1e6a782ff709de9a9
tree41d1845306f7700362ef282638e46dacad8ec717
parent981b696faf2d59a58d1dc8e258bba00b12e5de93
ext4: add ext4_sb_bread_nofail() helper function for ext4_free_branches()

The implicit __GFP_NOFAIL flag in ext4_sb_bread() was removed in commit
8a83ac54940d ("ext4: call bdev_getblk() from sb_getblk_gfp()"), meaning
the function can now fail under memory pressure.

Most callers of ext4_sb_bread() propagate the error to userspace and do not
remount the filesystem read-only. However, ext4_free_branches() handles
ext4_sb_bread() failure by remounting the filesystem read-only.

This implies that an ext3 filesystem (mounted via the ext4 driver) could be
forcibly remounted read-only due to a transient page allocation failure,
which is unacceptable.

To mitigate this, introduce a new helper function, ext4_sb_bread_nofail(),
which explicitly uses __GFP_NOFAIL, and use it in ext4_free_branches().

Fixes: 8a83ac54940d ("ext4: call bdev_getblk() from sb_getblk_gfp()")
Cc: stable@kernel.org
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ext4.h
fs/ext4/indirect.c
fs/ext4/super.c