]> Gentwo Git Trees - linux/.git/commit
media: uvcvideo: Fix assignment in if condition
authorDarshan Rathod <darshanrathod475@gmail.com>
Tue, 15 Jul 2025 11:30:56 +0000 (11:30 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Sat, 13 Sep 2025 16:34:57 +0000 (18:34 +0200)
commite67b5f8313229d058bddc88e29a73b9b6cdab7a9
treed954cf2037e38d34f8443d41808fbbcbb3e080f2
parentecba852dc9f4993f4f894ea1f352564560e19a3e
media: uvcvideo: Fix assignment in if condition

The function uvc_input_init() uses an assignment of the return value
of input_register_device() within the condition of an if statement.

This coding style is discouraged by the Linux kernel coding style guide
as it can be confused with a comparison and hide potential bugs.
The checkpatch.pl script flags this as an error:
"ERROR: do not use assignment in if condition"

Separate the assignment into its own statement before the conditional
check to improve code readability and adhere to the kernel's
coding standards.

Signed-off-by: Darshan Rathod <darshanrathod475@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans de Goede <hansg@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/usb/uvc/uvc_status.c