]> Gentwo Git Trees - linux/.git/commit
net/sched: Abort __tc_modify_qdisc if parent is a clsact/ingress qdisc
authorVictor Nogueira <victor@mojatatu.com>
Thu, 6 Nov 2025 20:56:20 +0000 (17:56 -0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 11 Nov 2025 00:57:56 +0000 (16:57 -0800)
commite781122d76f018ad17752ab1018b3ffbf7fad84e
treeddfbde2541c82b8ae242ab851309bcc2bd63420a
parent1534ff77757e44bcc4b98d0196bc5c0052fce5fa
net/sched: Abort __tc_modify_qdisc if parent is a clsact/ingress qdisc

Wang reported an illegal configuration [1] where the user attempts to add a
child qdisc to the ingress qdisc as follows:

tc qdisc add dev eth0 handle ffff:0 ingress
tc qdisc add dev eth0 handle ffe0:0 parent ffff:a fq

To solve this, we reject any configuration attempt to add a child qdisc to
ingress or clsact.

[1] https://lore.kernel.org/netdev/20251105022213.1981982-1-wangliang74@huawei.com/

Fixes: 5e50da01d0ce ("[NET_SCHED]: Fix endless loops (part 2): "simple" qdiscs")
Reported-by: Wang Liang <wangliang74@huawei.com>
Closes: https://lore.kernel.org/netdev/20251105022213.1981982-1-wangliang74@huawei.com/
Reviewed-by: Pedro Tammela <pctammela@mojatatu.ai>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Reviewed-by: Cong Wang <cwang@multikernel.io>
Link: https://patch.msgid.link/20251106205621.3307639-1-victor@mojatatu.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_api.c