]> Gentwo Git Trees - linux/.git/commit
net: phy: mxl-gpy: fix bogus error on USXGMII and integrated PHY
authorDaniel Golle <daniel@makrotopia.org>
Thu, 20 Nov 2025 14:17:13 +0000 (14:17 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 22 Nov 2025 02:10:28 +0000 (18:10 -0800)
commitec3803b5917b6ff2f86ea965d0985c95d8a85119
tree3a6966da89cefb00273afbe0960972e2eaf10b77
parenta14602fcae17a3f1cb8a8521bedf31728f9e7e39
net: phy: mxl-gpy: fix bogus error on USXGMII and integrated PHY

As the interface mode doesn't need to be updated on PHYs connected with
USXGMII and integrated PHYs, gpy_update_interface() should just return 0
in these cases rather than -EINVAL which has wrongly been introduced by
commit 7a495dde27ebc ("net: phy: mxl-gpy: Change gpy_update_interface()
function return type"), as this breaks support for those PHYs.

Fixes: 7a495dde27ebc ("net: phy: mxl-gpy: Change gpy_update_interface() function return type")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/f744f721a1fcc5e2e936428c62ff2c7d94d2a293.1763648168.git.daniel@makrotopia.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/mxl-gpy.c