]> Gentwo Git Trees - linux/.git/commit
slab: fix slab accounting imbalance due to defer_deactivate_slab()
authorVlastimil Babka <vbabka@suse.cz>
Thu, 23 Oct 2025 12:01:07 +0000 (14:01 +0200)
committerVlastimil Babka <vbabka@suse.cz>
Thu, 23 Oct 2025 14:53:21 +0000 (16:53 +0200)
commiteecd7cb64178efb35f89aa5134cf6ce36c0c66db
tree22f537fdeb564d05c28f43f8374c7a0974ef9441
parent6ed8bfd24ce1cb31742b09a3eb557cd008533eec
slab: fix slab accounting imbalance due to defer_deactivate_slab()

Since commit af92793e52c3 ("slab: Introduce kmalloc_nolock() and
kfree_nolock().") there's a possibility in alloc_single_from_new_slab()
that we discard the newly allocated slab if we can't spin and we fail to
trylock. As a result we don't perform inc_slabs_node() later in the
function. Instead we perform a deferred deactivate_slab() which can
either put the unacounted slab on partial list, or discard it
immediately while performing dec_slabs_node(). Either way will cause an
accounting imbalance.

Fix this by not marking the slab as frozen, and using free_slab()
instead of deactivate_slab() for non-frozen slabs in
free_deferred_objects(). For CONFIG_SLUB_TINY, that's the only possible
case. By not using discard_slab() we avoid dec_slabs_node().

Fixes: af92793e52c3 ("slab: Introduce kmalloc_nolock() and kfree_nolock().")
Link: https://patch.msgid.link/20251023-fix-slab-accounting-v2-1-0e62d50986ea@suse.cz
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
mm/slub.c