]> Gentwo Git Trees - linux/.git/commit
9p: fix cache/debug options printing in v9fs_show_options
authorEric Sandeen <sandeen@redhat.com>
Tue, 2 Dec 2025 22:30:53 +0000 (16:30 -0600)
committerDominique Martinet <asmadeus@codewreck.org>
Fri, 5 Dec 2025 12:53:16 +0000 (12:53 +0000)
commitf0445613314f474c1a0ec6fa8a5cd153a618f1b6
tree595ecc59e953c9c184722dc5a0d7be058113125e
parent1f3e4142c0eb178089ea0cbc97506a061470ad27
9p: fix cache/debug options printing in v9fs_show_options

commit 4eb3117888a92 changed the cache= option to accept either string
shortcuts or bitfield values. It also changed /proc/mounts to emit the
option as the hexadecimal numeric value rather than the shortcut string.

However, by printing "cache=%x" without the leading 0x, shortcuts such
as "cache=loose" will emit "cache=f" and 'f' is not a string that is
parseable by kstrtoint(), so remounting may fail if a remount with
"cache=f" is attempted.

debug=%x has had the same problem since options have been displayed in
c4fac9100456 ("9p: Implement show_options")

Fix these by adding the 0x prefix to the hexadecimal value shown in
/proc/mounts.

Fixes: 4eb3117888a92 ("fs/9p: Rework cache modes and add new options to Documentation")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Message-ID: <54b93378-dcf1-4b04-922d-c8b4393da299@redhat.com>
[Dominique: use %#x at Al Viro's suggestion, also handle debug]
Tested-by: Remi Pommarel <repk@triplefau.lt>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
fs/9p/v9fs.c