]> Gentwo Git Trees - linux/.git/commit
EDAC/ie31200: Fix error handling in ie31200_register_mci
authorMa Ke <make24@iscas.ac.cn>
Thu, 6 Nov 2025 08:47:35 +0000 (16:47 +0800)
committerTony Luck <tony.luck@intel.com>
Tue, 11 Nov 2025 01:06:10 +0000 (17:06 -0800)
commitf18e71cd6c546e65fab25829ed9a55cd1a0928b3
treebecd890fb734e145baf6ecfd4f39e9df17237558
parent8616025ae6e55b1fad4390fbb738f48c25e84216
EDAC/ie31200: Fix error handling in ie31200_register_mci

ie31200_register_mci() calls device_initialize() for priv->dev
unconditionally. However, in the error path, put_device() is not
called, leading to an imbalance. Similarly, in the unload path,
put_device() is missing.

Although edac_mc_free() eventually frees the memory, it does not
release the device initialized by device_initialize(). For code
readability and proper pairing of device_initialize()/put_device(),
add put_device() calls in both error and unload paths.

Found by code review.

Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
Link: https://patch.msgid.link/20251106084735.35017-1-make24@iscas.ac.cn
drivers/edac/ie31200_edac.c