]> Gentwo Git Trees - linux/.git/commit
nfsd: eliminate special handling of NFS4ERR_SEQ_MISORDERED
authorJeff Layton <jlayton@kernel.org>
Sun, 9 Feb 2025 12:31:28 +0000 (07:31 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 24 Feb 2025 01:07:19 +0000 (20:07 -0500)
commitf194595b9bd701e66dd0d2f13917cfab518a5c7f
tree13f17a42f00f9d4c3fbfeec1b71be47dde558a28
parentd64697927979cabb1898b52a9a6f6bee47b68481
nfsd: eliminate special handling of NFS4ERR_SEQ_MISORDERED

On a SEQ_MISORDERED error, the current code will reattempt the call, but
set the slot sequence ID to 1. I can find no mention of this remedy in
the spec, and it seems potentially dangerous. It's possible that the
last call was sent with seqid 1, and doing this will cause a
retransmission of the reply.

Drop this special handling, and always treat SEQ_MISORDERED like
BADSLOT. Retry the call, but leak the slot so that it is no longer used.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4callback.c