]> Gentwo Git Trees - linux/.git/commit
drm/sched: Document race condition in drm_sched_fini()
authorPhilipp Stanner <phasta@kernel.org>
Wed, 13 Aug 2025 08:56:55 +0000 (10:56 +0200)
committerPhilipp Stanner <phasta@kernel.org>
Thu, 28 Aug 2025 08:27:18 +0000 (10:27 +0200)
commitf4c75f975cf50fa2e1fd96c5aafe5aa62e55fbe4
tree494f25b990bcdc696d9eded97a8aaf818b0d89a0
parent77a62e557f54ecf6305e7ed6fb05d02e8748bffb
drm/sched: Document race condition in drm_sched_fini()

In drm_sched_fini() all entities are marked as stopped - without taking
the appropriate lock, because that would deadlock. That means that
drm_sched_fini() and drm_sched_entity_push_job() can race against each
other.

This should most likely be fixed by establishing the rule that all
entities associated with a scheduler must be torn down first. Then,
however, the locking should be removed from drm_sched_fini() alltogether
with an appropriate comment.

Reported-by: James Flowers <bold.zone2373@fastmail.com>
Link: https://lore.kernel.org/dri-devel/20250720235748.2798-1-bold.zone2373@fastmail.com/
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Philipp Stanner <phasta@kernel.org>
Link: https://lore.kernel.org/r/20250813085654.102504-2-phasta@kernel.org
drivers/gpu/drm/scheduler/sched_main.c