]> Gentwo Git Trees - linux/.git/commit
net: dsa: mv88e6xxx: Fix fwnode reference leaks in mv88e6xxx_port_setup_leds
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 1 Sep 2025 07:32:23 +0000 (15:32 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 3 Sep 2025 00:04:03 +0000 (17:04 -0700)
commitf63e7c8a83892781f6ceb55566f9497639c44555
treeda6da60c180f8d188e76500083d8b05022a186c4
parent3a5f55500f3e93cf4d62351c753452279b088b4b
net: dsa: mv88e6xxx: Fix fwnode reference leaks in mv88e6xxx_port_setup_leds

Fix multiple fwnode reference leaks:

1. The function calls fwnode_get_named_child_node() to get the "leds" node,
   but never calls fwnode_handle_put(leds) to release this reference.

2. Within the fwnode_for_each_child_node() loop, the early return
   paths that don't properly release the "led" fwnode reference.

This fix follows the same pattern as commit d029edefed39
("net dsa: qca8k: fix usages of device_get_named_child_node()")

Fixes: 94a2a84f5e9e ("net: dsa: mv88e6xxx: Support LED control")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patch.msgid.link/20250901073224.2273103-1-linmq006@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/mv88e6xxx/leds.c