]> Gentwo Git Trees - linux/.git/commit
drm/bridge: dw-hdmi-qp: Fixup timer base setup
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Wed, 3 Sep 2025 18:51:00 +0000 (21:51 +0300)
committerHeiko Stuebner <heiko@sntech.de>
Wed, 15 Oct 2025 20:28:03 +0000 (22:28 +0200)
commitf7a1de0d86221000dc0699a8b48ad3a848e766d9
tree31fc94732ecedc86be7db4e298b8c62d1a131cd8
parente4a2d54a2f1a9c9a1971651832c8f0ad9d3782c4
drm/bridge: dw-hdmi-qp: Fixup timer base setup

Currently the TIMER_BASE_CONFIG0 register gets initialized to a fixed
value as initially found in vendor driver code supporting the RK3588
SoC.  As a matter of fact the value matches the rate of the HDMI TX
reference clock, which is roughly 428.57 MHz.

However, on RK3576 SoC that rate is slightly lower, i.e. 396.00 MHz, and
the incorrect register configuration breaks CEC functionality.

Set the timer base according to the actual reference clock rate that
shall be provided by the platform driver.  Otherwise fallback to the
vendor default.

While at it, also drop the unnecessary empty lines in
dw_hdmi_qp_init_hw().

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Reviewed-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://lore.kernel.org/r/20250903-rk3588-hdmi-cec-v4-2-fa25163c4b08@collabora.com
drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
include/drm/bridge/dw_hdmi_qp.h