]> Gentwo Git Trees - linux/.git/commit
ACPI: TAD: Rearrange runtime PM operations in acpi_tad_remove()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 21 Oct 2025 17:33:39 +0000 (19:33 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 27 Oct 2025 19:32:13 +0000 (20:32 +0100)
commitf9f5e22b75b87a98e7645cb1f27c7b457c3c7edb
tree9eb4e37863e82c5c7be567e42a1e1be85ed6a783
parentdcb6fa37fd7bc9c3d2b066329b0d27dedf8becaa
ACPI: TAD: Rearrange runtime PM operations in acpi_tad_remove()

It is not necessary to resume the device upfront in acpi_tad_remove()
because both acpi_tad_disable_timer() and acpi_tad_clear_status()
attempt to resume it, but it is better to prevent it from suspending
between these calls by incrementing its runtime PM usage counter.

Accordingly, replace the pm_runtime_get_sync() call in acpi_tad_remove()
with a pm_runtime_get_noresume() one and put the latter right before the
first invocation of acpi_tad_disable_timer().

In addition, use pm_runtime_put_noidle() to drop the device's runtime
PM usage counter after using pm_runtime_get_noresume() to bump it up
to follow a common pattern and use pm_runtime_suspend() for suspending
the device afterward.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Link: https://patch.msgid.link/5031965.GXAFRqVoOG@rafael.j.wysocki
drivers/acpi/acpi_tad.c