]> Gentwo Git Trees - linux/.git/commit
x86/cpu/intel: Replace PAT erratum model/family magic numbers with symbolic IFM refer...
authorDave Hansen <dave.hansen@linux.intel.com>
Thu, 29 Aug 2024 22:00:42 +0000 (15:00 -0700)
committerIngo Molnar <mingo@kernel.org>
Tue, 3 Sep 2024 09:18:58 +0000 (11:18 +0200)
commitfd82221a59fa5ce9dc7523e11c5e995104a28cb0
tree4e5b3e60591ec717399ff04e9f64430e9c38b0bc
parentc9f016e72b5cc7d4d68fac51f8e72c8c7a69c06e
x86/cpu/intel: Replace PAT erratum model/family magic numbers with symbolic IFM references

There's an erratum that prevents the PAT from working correctly:

   https://www.intel.com/content/dam/www/public/us/en/documents/specification-updates/pentium-dual-core-specification-update.pdf
   # Document 316515 Version 010

The kernel currently disables PAT support on those CPUs, but it
does it with some magic numbers.

Replace the magic numbers with the new "IFM" macros.

Make the check refer to the last affected CPU (INTEL_CORE_YONAH)
rather than the first fixed one. This makes it easier to find the
documentation of the erratum since Intel documents where it is
broken and not where it is fixed.

I don't think the Pentium Pro (or Pentium II) is actually affected.
But the old check included them, so it can't hurt to keep doing the
same.  I'm also not completely sure about the "Pentium M" CPUs
(models 0x9 and 0xd).  But, again, they were included in in the
old checks and were close Pentium III derivatives, so are likely
affected.

While we're at it, revise the comment referring to the erratum name
and making sure it is a quote of the language from the actual errata
doc.  That should make it easier to find in the future when the URL
inevitably changes.

Why bother with this in the first place? It actually gets rid of one
of the very few remaining direct references to c->x86{,_model}.

No change in functionality intended.

Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Len Brown <len.brown@intel.com>
Link: https://lore.kernel.org/r/20240829220042.1007820-1-dave.hansen@linux.intel.com
arch/x86/include/asm/intel-family.h
arch/x86/kernel/cpu/intel.c