]> Gentwo Git Trees - linux/.git/commit
ASoC: codecs: hda: Fix RPM usage count underflow
authorCezary Rojewski <cezary.rojewski@intel.com>
Fri, 30 May 2025 14:10:17 +0000 (16:10 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 2 Jun 2025 11:26:44 +0000 (12:26 +0100)
commitff0045de4ee0288dec683690f66f2f369b7d3466
treea6e58f93033a710e02ed4c3f068b37906f6668fa
parentdf7996076b1e1ba8a0690542d0e40f703f2f9eb7
ASoC: codecs: hda: Fix RPM usage count underflow

RPM manipulation in hda_codec_probe_complete()'s error path is
superfluous and leads to RPM usage count underflow if the
build-controls operation fails.

hda_codec_probe_complete() is called in:

1) hda_codec_probe() for all non-HDMI codecs
2) in card->late_probe() for HDMI codecs

Error path for hda_codec_probe() takes care of bus' RPM already.
For 2) if late_probe() fails, ASoC performs card cleanup what
triggers hda_codec_remote() - same treatment is in 1).

Fixes: b5df2a7dca1c ("ASoC: codecs: Add HD-Audio codec driver")
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://patch.msgid.link/20250530141025.2942936-2-cezary.rojewski@intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/hda.c