]> Gentwo Git Trees - linux/.git/commitdiff
mfd: da9055: Simplify the error handling path in da9055_device_init()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 25 Oct 2025 11:27:16 +0000 (13:27 +0200)
committerLee Jones <lee@kernel.org>
Thu, 6 Nov 2025 14:05:02 +0000 (14:05 +0000)
If mfd_add_devices() fails, there is no need to call mfd_remove_devices().
The needed clean-up is already done in the error handling path of
mfd_add_devices().

So, remove the unneeded (and harmless) call.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://patch.msgid.link/871f52e7ab5d12853bc39f36ac78b5a8e484d863.1761391599.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/da9055-core.c

index 8c989b74f924e334ff0fec6b3455d314db913ae8..158590ad37d45aefecc66ec000c9946ccf782758 100644 (file)
@@ -387,7 +387,6 @@ int da9055_device_init(struct da9055 *da9055)
        return 0;
 
 err:
-       mfd_remove_devices(da9055->dev);
        regmap_del_irq_chip(da9055->chip_irq, da9055->irq_data);
        return ret;
 }