]> Gentwo Git Trees - linux/.git/commitdiff
soc: amlogic: canvas: simplify lookup error handling
authorJohan Hovold <johan@kernel.org>
Fri, 26 Sep 2025 14:24:54 +0000 (16:24 +0200)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 21 Oct 2025 12:20:29 +0000 (14:20 +0200)
Simplify the canvas lookup error handling by dropping the OF node
reference sooner.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://patch.msgid.link/20250926142454.5929-3-johan@kernel.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
drivers/soc/amlogic/meson-canvas.c

index 0711088da5dcd1e859a955ab96251386efbbe832..79681afea8c61206eed6ca3910c128a0bf733b09 100644 (file)
@@ -60,12 +60,9 @@ struct meson_canvas *meson_canvas_get(struct device *dev)
                return ERR_PTR(-ENODEV);
 
        canvas_pdev = of_find_device_by_node(canvas_node);
-       if (!canvas_pdev) {
-               of_node_put(canvas_node);
-               return ERR_PTR(-EPROBE_DEFER);
-       }
-
        of_node_put(canvas_node);
+       if (!canvas_pdev)
+               return ERR_PTR(-EPROBE_DEFER);
 
        /*
         * If priv is NULL, it's probably because the canvas hasn't