]> Gentwo Git Trees - linux/.git/commitdiff
drm/xe: Remove driver side BAR release before resize
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 13 Nov 2025 16:26:25 +0000 (18:26 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 14 Nov 2025 18:34:11 +0000 (12:34 -0600)
PCI core handles releasing device's resources and their rollback in case of
failure of a BAR resizing operation. Releasing resource prior to calling
pci_resize_resource() prevents PCI core from restoring the BARs as they
were.

Remove driver-side release of BARs from the xe driver.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patch.msgid.link/20251113162628.5946-9-ilpo.jarvinen@linux.intel.com
drivers/gpu/drm/xe/xe_vram.c

index 00dd027057df1ece9bddcc36de4385e9befa18e9..5aacab9358a4961117a9e6526510ae80a5a267e8 100644 (file)
@@ -33,9 +33,6 @@ _resize_bar(struct xe_device *xe, int resno, resource_size_t size)
        int bar_size = pci_rebar_bytes_to_size(size);
        int ret;
 
-       if (pci_resource_len(pdev, resno))
-               pci_release_resource(pdev, resno);
-
        ret = pci_resize_resource(pdev, resno, bar_size, 0);
        if (ret) {
                drm_info(&xe->drm, "Failed to resize BAR%d to %dM (%pe). Consider enabling 'Resizable BAR' support in your BIOS\n",