]> Gentwo Git Trees - linux/.git/commitdiff
drm/mediatek: mtk_hdmi: Drop redundant clock retrieval in mtk_hdmi_get_cec_dev
authorLouis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Thu, 23 Oct 2025 10:32:27 +0000 (12:32 +0200)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Mon, 17 Nov 2025 15:03:44 +0000 (15:03 +0000)
In mtk_hdmi driver, when the CEC device parsing logic was moved from
mtk_hdmi_dt_parse_pdata function to the new mtk_hdmi_get_cec_dev sub
function, the call to mtk_hdmi_get_all_clk was kept in both functions,
whereas it was only called once in the original mtk_hdmi_dt_parse_pdata
code and does not need to be called a second time.
So, remove this call from mtk_hdmi_get_cec_dev to keep the same sequence
as previously.

Fixes: 7485be967f7f ("drm/mediatek: mtk_hdmi: Move CEC device parsing in new function")
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20251023-mediatek-drm-hdmi-v2-v11-1-7873ec4a1edf@collabora.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_hdmi.c

index 306e2c90731144ec22a9d269ef44843b71db11f2..8ee6491eaeed16c4b23a0931ab66e6717e3d129e 100644 (file)
@@ -1358,10 +1358,6 @@ static int mtk_hdmi_get_cec_dev(struct mtk_hdmi *hdmi, struct device *dev, struc
        struct device_node *cec_np;
        int ret;
 
-       ret = mtk_hdmi_get_all_clk(hdmi, np);
-       if (ret)
-               return dev_err_probe(dev, ret, "Failed to get clocks\n");
-
        /* The CEC module handles HDMI hotplug detection */
        cec_np = of_get_compatible_child(np->parent, "mediatek,mt8173-cec");
        if (!cec_np)