]> Gentwo Git Trees - linux/.git/commitdiff
rtla/timerlat: Exit top main loop on any non-zero wait_retval
authorCrystal Wood <crwood@redhat.com>
Wed, 12 Nov 2025 15:25:28 +0000 (09:25 -0600)
committerTomas Glozar <tglozar@redhat.com>
Fri, 21 Nov 2025 09:30:27 +0000 (10:30 +0100)
Comparing to exactly 1 will fail if more than one ring buffer
event was seen since the last call to timerlat_bpf_wait(), which
can happen in some race scenarios.

Signed-off-by: Crystal Wood <crwood@redhat.com>
Link: https://lore.kernel.org/r/20251112152529.956778-5-crwood@redhat.com
Signed-off-by: Tomas Glozar <tglozar@redhat.com>
tools/tracing/rtla/src/timerlat_top.c

index fec113ce370e9c7a0e3f4624a6eb13ade6c6f9a0..29c2c1f717ed792122d5854556c7230aa97d412a 100644 (file)
@@ -878,7 +878,7 @@ timerlat_top_bpf_main_loop(struct osnoise_tool *tool)
                if (!params->common.quiet)
                        timerlat_print_stats(tool);
 
-               if (wait_retval == 1) {
+               if (wait_retval != 0) {
                        /* Stopping requested by tracer */
                        actions_perform(&params->common.threshold_actions);