]> Gentwo Git Trees - linux/.git/commitdiff
net: bcmgenet: extract GRXRINGS from .get_rxnfc
authorBreno Leitao <leitao@debian.org>
Thu, 27 Nov 2025 10:17:16 +0000 (02:17 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 29 Nov 2025 03:56:22 +0000 (19:56 -0800)
Commit 84eaf4359c36 ("net: ethtool: add get_rx_ring_count callback to
optimize RX ring queries") added specific support for GRXRINGS callback,
simplifying .get_rxnfc.

Remove the handling of GRXRINGS in .get_rxnfc() by moving it to the new
.get_rx_ring_count().

This simplifies the RX ring count retrieval and aligns bcmgenet with the
new ethtool API for querying RX ring parameters.

Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20251127-grxrings_broadcom-v1-2-b0b182864950@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/genet/bcmgenet.c

index d99ef92feb82bbad674b28dbd29bbecee4c796b8..05512aa10c209c6003bf4eddb9eb6cc73064d875 100644 (file)
@@ -1640,6 +1640,13 @@ static int bcmgenet_get_num_flows(struct bcmgenet_priv *priv)
        return res;
 }
 
+static u32 bcmgenet_get_rx_ring_count(struct net_device *dev)
+{
+       struct bcmgenet_priv *priv = netdev_priv(dev);
+
+       return priv->hw_params->rx_queues ?: 1;
+}
+
 static int bcmgenet_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
                              u32 *rule_locs)
 {
@@ -1649,9 +1656,6 @@ static int bcmgenet_get_rxnfc(struct net_device *dev, struct ethtool_rxnfc *cmd,
        int i = 0;
 
        switch (cmd->cmd) {
-       case ETHTOOL_GRXRINGS:
-               cmd->data = priv->hw_params->rx_queues ?: 1;
-               break;
        case ETHTOOL_GRXCLSRLCNT:
                cmd->rule_cnt = bcmgenet_get_num_flows(priv);
                cmd->data = MAX_NUM_OF_FS_RULES | RX_CLS_LOC_SPECIAL;
@@ -1700,6 +1704,7 @@ static const struct ethtool_ops bcmgenet_ethtool_ops = {
        .get_ts_info            = ethtool_op_get_ts_info,
        .get_rxnfc              = bcmgenet_get_rxnfc,
        .set_rxnfc              = bcmgenet_set_rxnfc,
+       .get_rx_ring_count      = bcmgenet_get_rx_ring_count,
        .get_pauseparam         = bcmgenet_get_pauseparam,
        .set_pauseparam         = bcmgenet_set_pauseparam,
 };