]> Gentwo Git Trees - linux/.git/commitdiff
net: dsa: tag_trailer: use the dsa_xmit_port_mask() helper
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 27 Nov 2025 12:09:00 +0000 (14:09 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sat, 29 Nov 2025 04:03:41 +0000 (20:03 -0800)
The "trailer" tagging protocol populates a bit mask for the TX ports, so
we can use dsa_xmit_port_mask() to centralize the decision of how to set
that field.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20251127120902.292555-14-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/tag_trailer.c

index 22742a53d6f42fef709955c2a7fc8f52812b0c8e..4dce24cfe6a7169dfed0a774a514a40d85168e9a 100644 (file)
 
 static struct sk_buff *trailer_xmit(struct sk_buff *skb, struct net_device *dev)
 {
-       struct dsa_port *dp = dsa_user_to_port(dev);
        u8 *trailer;
 
        trailer = skb_put(skb, 4);
        trailer[0] = 0x80;
-       trailer[1] = 1 << dp->index;
+       trailer[1] = dsa_xmit_port_mask(skb, dev);
        trailer[2] = 0x10;
        trailer[3] = 0x00;