drm/msm/adreno: Move adreno_gpu_func to catalogue

In A6x family (which is a pretty big one), there are separate
adreno_func definitions for each sub-generations. To streamline the
identification of the correct struct for a gpu, move it to the
catalogue and move the gpu_init routine to struct adreno_gpu_funcs.

Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/689003/
Message-ID: <20251118-kaana-gpu-support-v4-6-86eeb8e93fb6@oss.qualcomm.com>
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>

diff --git a/drivers/gpu/drm/msm/adreno/a2xx_catalog.c b/drivers/gpu/drm/msm/adreno/a2xx_catalog.c
index 5ddd015f930d9a7dd04e2d2035daa0b2f5ff3f27..e9dbf3ddf89e484fac8a0267291f708b485c9aae 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a2xx_catalog.c
+++ b/drivers/gpu/drm/msm/adreno/a2xx_catalog.c
@@ -7,6 +7,7 @@
  */
 
 #include "adreno_gpu.h"
+#include "a2xx_gpu.h"
 
 static const struct adreno_info a2xx_gpus[] = {
        {
@@ -19,7 +20,7 @@ static const struct adreno_info a2xx_gpus[] = {
                },
                .gmem  = SZ_256K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a2xx_gpu_init,
+               .funcs = &a2xx_gpu_funcs,
        }, { /* a200 on i.mx51 has only 128kib gmem */
                .chip_ids = ADRENO_CHIP_IDS(0x02000001),
                .family = ADRENO_2XX_GEN1,
@@ -30,7 +31,7 @@ static const struct adreno_info a2xx_gpus[] = {
                },
                .gmem  = SZ_128K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a2xx_gpu_init,
+               .funcs = &a2xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x02020000),
                .family = ADRENO_2XX_GEN2,
@@ -41,7 +42,7 @@ static const struct adreno_info a2xx_gpus[] = {
                },
                .gmem  = SZ_512K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a2xx_gpu_init,
+               .funcs = &a2xx_gpu_funcs,
        }
 };
 DECLARE_ADRENO_GPULIST(a2xx);

diff --git a/drivers/gpu/drm/msm/adreno/a2xx_gpu.c b/drivers/gpu/drm/msm/adreno/a2xx_gpu.c
index 963c0f669ee50d4568b521e2e8548e04d606d9ca..1b1ee14b65cf03080372d46c9dc0e4c971f36cf3 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a2xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a2xx_gpu.c
@@ -486,39 +486,18 @@ static u32 a2xx_get_rptr(struct msm_gpu *gpu, struct msm_ringbuffer *ring)
        return ring->memptrs->rptr;
 }
 
-static const struct adreno_gpu_funcs funcs = {
-       .base = {
-               .get_param = adreno_get_param,
-               .set_param = adreno_set_param,
-               .hw_init = a2xx_hw_init,
-               .pm_suspend = msm_gpu_pm_suspend,
-               .pm_resume = msm_gpu_pm_resume,
-               .recover = a2xx_recover,
-               .submit = a2xx_submit,
-               .active_ring = adreno_active_ring,
-               .irq = a2xx_irq,
-               .destroy = a2xx_destroy,
-#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
-               .show = adreno_show,
-#endif
-               .gpu_state_get = a2xx_gpu_state_get,
-               .gpu_state_put = adreno_gpu_state_put,
-               .create_vm = a2xx_create_vm,
-               .get_rptr = a2xx_get_rptr,
-       },
-};
-
 static const struct msm_gpu_perfcntr perfcntrs[] = {
 /* TODO */
 };
 
-struct msm_gpu *a2xx_gpu_init(struct drm_device *dev)
+static struct msm_gpu *a2xx_gpu_init(struct drm_device *dev)
 {
        struct a2xx_gpu *a2xx_gpu = NULL;
        struct adreno_gpu *adreno_gpu;
        struct msm_gpu *gpu;
        struct msm_drm_private *priv = dev->dev_private;
        struct platform_device *pdev = priv->gpu_pdev;
+       struct adreno_platform_config *config = pdev->dev.platform_data;
        int ret;
 
        if (!pdev) {
@@ -539,7 +518,7 @@ struct msm_gpu *a2xx_gpu_init(struct drm_device *dev)
        gpu->perfcntrs = perfcntrs;
        gpu->num_perfcntrs = ARRAY_SIZE(perfcntrs);
 
-       ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs, 1);
+       ret = adreno_gpu_init(dev, pdev, adreno_gpu, config->info->funcs, 1);
        if (ret)
                goto fail;
 
@@ -558,3 +537,26 @@ struct msm_gpu *a2xx_gpu_init(struct drm_device *dev)
 
        return ERR_PTR(ret);
 }
+
+const struct adreno_gpu_funcs a2xx_gpu_funcs = {
+       .base = {
+               .get_param = adreno_get_param,
+               .set_param = adreno_set_param,
+               .hw_init = a2xx_hw_init,
+               .pm_suspend = msm_gpu_pm_suspend,
+               .pm_resume = msm_gpu_pm_resume,
+               .recover = a2xx_recover,
+               .submit = a2xx_submit,
+               .active_ring = adreno_active_ring,
+               .irq = a2xx_irq,
+               .destroy = a2xx_destroy,
+#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
+               .show = adreno_show,
+#endif
+               .gpu_state_get = a2xx_gpu_state_get,
+               .gpu_state_put = adreno_gpu_state_put,
+               .create_vm = a2xx_create_vm,
+               .get_rptr = a2xx_get_rptr,
+       },
+       .init = a2xx_gpu_init,
+};

diff --git a/drivers/gpu/drm/msm/adreno/a2xx_gpu.h b/drivers/gpu/drm/msm/adreno/a2xx_gpu.h
index 53702f19990f39b1d3d9a30e2e02792f5c23968d..162ef98951f5fc8ede2e9ae53ab4140edc56cff8 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a2xx_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/a2xx_gpu.h
@@ -19,6 +19,8 @@ struct a2xx_gpu {
 };
 #define to_a2xx_gpu(x) container_of(x, struct a2xx_gpu, base)
 
+extern const struct adreno_gpu_funcs a2xx_gpu_funcs;
+
 struct msm_mmu *a2xx_gpummu_new(struct device *dev, struct msm_gpu *gpu);
 void a2xx_gpummu_params(struct msm_mmu *mmu, dma_addr_t *pt_base,
                dma_addr_t *tran_error);

diff --git a/drivers/gpu/drm/msm/adreno/a3xx_catalog.c b/drivers/gpu/drm/msm/adreno/a3xx_catalog.c
index 1498e6532f62c707754502c713b3bcc60a3c1478..6ae8716fc08a86bd349cf99e71441bf23719a906 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a3xx_catalog.c
+++ b/drivers/gpu/drm/msm/adreno/a3xx_catalog.c
@@ -7,6 +7,7 @@
  */
 
 #include "adreno_gpu.h"
+#include "a3xx_gpu.h"
 
 static const struct adreno_info a3xx_gpus[] = {
        {
@@ -18,7 +19,7 @@ static const struct adreno_info a3xx_gpus[] = {
                },
                .gmem  = SZ_128K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a3xx_gpu_init,
+               .funcs = &a3xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x03000520),
                .family = ADRENO_3XX,
@@ -29,7 +30,7 @@ static const struct adreno_info a3xx_gpus[] = {
                },
                .gmem  = SZ_256K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a3xx_gpu_init,
+               .funcs = &a3xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x03000600),
                .family = ADRENO_3XX,
@@ -40,7 +41,7 @@ static const struct adreno_info a3xx_gpus[] = {
                },
                .gmem  = SZ_128K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a3xx_gpu_init,
+               .funcs = &a3xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x03000620),
                .family = ADRENO_3XX,
@@ -51,7 +52,7 @@ static const struct adreno_info a3xx_gpus[] = {
                },
                .gmem = SZ_128K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a3xx_gpu_init,
+               .funcs = &a3xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(
                        0x03020000,
@@ -66,7 +67,7 @@ static const struct adreno_info a3xx_gpus[] = {
                },
                .gmem  = SZ_512K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a3xx_gpu_init,
+               .funcs = &a3xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(
                        0x03030000,
@@ -81,7 +82,7 @@ static const struct adreno_info a3xx_gpus[] = {
                },
                .gmem  = SZ_1M,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a3xx_gpu_init,
+               .funcs = &a3xx_gpu_funcs,
        }
 };
 DECLARE_ADRENO_GPULIST(a3xx);

diff --git a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
index a956cd79195e0e13d6b2a1920b15e9aa12f1d060..f22d33e99e815ab3da0296366a91f5c6e9f918ec 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a3xx_gpu.c
@@ -508,29 +508,6 @@ static u32 a3xx_get_rptr(struct msm_gpu *gpu, struct msm_ringbuffer *ring)
        return ring->memptrs->rptr;
 }
 
-static const struct adreno_gpu_funcs funcs = {
-       .base = {
-               .get_param = adreno_get_param,
-               .set_param = adreno_set_param,
-               .hw_init = a3xx_hw_init,
-               .pm_suspend = msm_gpu_pm_suspend,
-               .pm_resume = msm_gpu_pm_resume,
-               .recover = a3xx_recover,
-               .submit = a3xx_submit,
-               .active_ring = adreno_active_ring,
-               .irq = a3xx_irq,
-               .destroy = a3xx_destroy,
-#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
-               .show = adreno_show,
-#endif
-               .gpu_busy = a3xx_gpu_busy,
-               .gpu_state_get = a3xx_gpu_state_get,
-               .gpu_state_put = adreno_gpu_state_put,
-               .create_vm = adreno_create_vm,
-               .get_rptr = a3xx_get_rptr,
-       },
-};
-
 static const struct msm_gpu_perfcntr perfcntrs[] = {
        { REG_A3XX_SP_PERFCOUNTER6_SELECT, REG_A3XX_RBBM_PERFCTR_SP_6_LO,
                        SP_ALU_ACTIVE_CYCLES, "ALUACTIVE" },
@@ -538,13 +515,14 @@ static const struct msm_gpu_perfcntr perfcntrs[] = {
                        SP_FS_FULL_ALU_INSTRUCTIONS, "ALUFULL" },
 };
 
-struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
+static struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
 {
        struct a3xx_gpu *a3xx_gpu = NULL;
        struct adreno_gpu *adreno_gpu;
        struct msm_gpu *gpu;
        struct msm_drm_private *priv = dev->dev_private;
        struct platform_device *pdev = priv->gpu_pdev;
+       struct adreno_platform_config *config = pdev->dev.platform_data;
        struct icc_path *ocmem_icc_path;
        struct icc_path *icc_path;
        int ret;
@@ -569,7 +547,7 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
 
        adreno_gpu->registers = a3xx_registers;
 
-       ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs, 1);
+       ret = adreno_gpu_init(dev, pdev, adreno_gpu, config->info->funcs, 1);
        if (ret)
                goto fail;
 
@@ -613,3 +591,27 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
 
        return ERR_PTR(ret);
 }
+
+const struct adreno_gpu_funcs a3xx_gpu_funcs = {
+       .base = {
+               .get_param = adreno_get_param,
+               .set_param = adreno_set_param,
+               .hw_init = a3xx_hw_init,
+               .pm_suspend = msm_gpu_pm_suspend,
+               .pm_resume = msm_gpu_pm_resume,
+               .recover = a3xx_recover,
+               .submit = a3xx_submit,
+               .active_ring = adreno_active_ring,
+               .irq = a3xx_irq,
+               .destroy = a3xx_destroy,
+#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
+               .show = adreno_show,
+#endif
+               .gpu_busy = a3xx_gpu_busy,
+               .gpu_state_get = a3xx_gpu_state_get,
+               .gpu_state_put = adreno_gpu_state_put,
+               .create_vm = adreno_create_vm,
+               .get_rptr = a3xx_get_rptr,
+       },
+       .init = a3xx_gpu_init,
+};

diff --git a/drivers/gpu/drm/msm/adreno/a3xx_gpu.h b/drivers/gpu/drm/msm/adreno/a3xx_gpu.h
index c555fb13e0d7e2517ae9968b1d75cfb37807db26..3d4ec9dbd918e14b92bbf203be537307a4e2b26c 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a3xx_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/a3xx_gpu.h
@@ -23,4 +23,6 @@ struct a3xx_gpu {
 };
 #define to_a3xx_gpu(x) container_of(x, struct a3xx_gpu, base)
 
+extern const struct adreno_gpu_funcs a3xx_gpu_funcs;
+
 #endif /* __A3XX_GPU_H__ */

diff --git a/drivers/gpu/drm/msm/adreno/a4xx_catalog.c b/drivers/gpu/drm/msm/adreno/a4xx_catalog.c
index 09f9f228b75e086d09f41b858a3d43dd7da6284d..9192586f7ef0aa0bb79c42b237cc540c40cf70c4 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a4xx_catalog.c
+++ b/drivers/gpu/drm/msm/adreno/a4xx_catalog.c
@@ -7,6 +7,7 @@
  */
 
 #include "adreno_gpu.h"
+#include "a4xx_gpu.h"
 
 static const struct adreno_info a4xx_gpus[] = {
        {
@@ -19,7 +20,7 @@ static const struct adreno_info a4xx_gpus[] = {
                },
                .gmem  = SZ_256K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a4xx_gpu_init,
+               .funcs = &a4xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x04020000),
                .family = ADRENO_4XX,
@@ -30,7 +31,7 @@ static const struct adreno_info a4xx_gpus[] = {
                },
                .gmem  = (SZ_1M + SZ_512K),
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a4xx_gpu_init,
+               .funcs = &a4xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x04030002),
                .family = ADRENO_4XX,
@@ -41,7 +42,7 @@ static const struct adreno_info a4xx_gpus[] = {
                },
                .gmem  = (SZ_1M + SZ_512K),
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init  = a4xx_gpu_init,
+               .funcs = &a4xx_gpu_funcs,
        }
 };
 DECLARE_ADRENO_GPULIST(a4xx);

diff --git a/drivers/gpu/drm/msm/adreno/a4xx_gpu.c b/drivers/gpu/drm/msm/adreno/a4xx_gpu.c
index 83f6329accbacee076a583bdda9816e1cbcdfb59..db06c06067aeb2cf3e2b5da7b36cac2bc31a7bee 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a4xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a4xx_gpu.c
@@ -627,37 +627,14 @@ static u32 a4xx_get_rptr(struct msm_gpu *gpu, struct msm_ringbuffer *ring)
        return ring->memptrs->rptr;
 }
 
-static const struct adreno_gpu_funcs funcs = {
-       .base = {
-               .get_param = adreno_get_param,
-               .set_param = adreno_set_param,
-               .hw_init = a4xx_hw_init,
-               .pm_suspend = a4xx_pm_suspend,
-               .pm_resume = a4xx_pm_resume,
-               .recover = a4xx_recover,
-               .submit = a4xx_submit,
-               .active_ring = adreno_active_ring,
-               .irq = a4xx_irq,
-               .destroy = a4xx_destroy,
-#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
-               .show = adreno_show,
-#endif
-               .gpu_busy = a4xx_gpu_busy,
-               .gpu_state_get = a4xx_gpu_state_get,
-               .gpu_state_put = adreno_gpu_state_put,
-               .create_vm = adreno_create_vm,
-               .get_rptr = a4xx_get_rptr,
-       },
-       .get_timestamp = a4xx_get_timestamp,
-};
-
-struct msm_gpu *a4xx_gpu_init(struct drm_device *dev)
+static struct msm_gpu *a4xx_gpu_init(struct drm_device *dev)
 {
        struct a4xx_gpu *a4xx_gpu = NULL;
        struct adreno_gpu *adreno_gpu;
        struct msm_gpu *gpu;
        struct msm_drm_private *priv = dev->dev_private;
        struct platform_device *pdev = priv->gpu_pdev;
+       struct adreno_platform_config *config = pdev->dev.platform_data;
        struct icc_path *ocmem_icc_path;
        struct icc_path *icc_path;
        int ret;
@@ -680,7 +657,7 @@ struct msm_gpu *a4xx_gpu_init(struct drm_device *dev)
        gpu->perfcntrs = NULL;
        gpu->num_perfcntrs = 0;
 
-       ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs, 1);
+       ret = adreno_gpu_init(dev, pdev, adreno_gpu, config->info->funcs, 1);
        if (ret)
                goto fail;
 
@@ -726,3 +703,28 @@ struct msm_gpu *a4xx_gpu_init(struct drm_device *dev)
 
        return ERR_PTR(ret);
 }
+
+const struct adreno_gpu_funcs a4xx_gpu_funcs = {
+       .base = {
+               .get_param = adreno_get_param,
+               .set_param = adreno_set_param,
+               .hw_init = a4xx_hw_init,
+               .pm_suspend = a4xx_pm_suspend,
+               .pm_resume = a4xx_pm_resume,
+               .recover = a4xx_recover,
+               .submit = a4xx_submit,
+               .active_ring = adreno_active_ring,
+               .irq = a4xx_irq,
+               .destroy = a4xx_destroy,
+#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
+               .show = adreno_show,
+#endif
+               .gpu_busy = a4xx_gpu_busy,
+               .gpu_state_get = a4xx_gpu_state_get,
+               .gpu_state_put = adreno_gpu_state_put,
+               .create_vm = adreno_create_vm,
+               .get_rptr = a4xx_get_rptr,
+       },
+       .init = a4xx_gpu_init,
+       .get_timestamp = a4xx_get_timestamp,
+};

diff --git a/drivers/gpu/drm/msm/adreno/a4xx_gpu.h b/drivers/gpu/drm/msm/adreno/a4xx_gpu.h
index a01448cba2eaf0b5101cb4fc939454c7f0f8b8b1..71b164439f62eee48c75f697c8b7da0b4b3a8ac8 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a4xx_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/a4xx_gpu.h
@@ -20,4 +20,6 @@ struct a4xx_gpu {
 };
 #define to_a4xx_gpu(x) container_of(x, struct a4xx_gpu, base)
 
+extern const struct adreno_gpu_funcs a4xx_gpu_funcs;
+
 #endif /* __A4XX_GPU_H__ */

diff --git a/drivers/gpu/drm/msm/adreno/a5xx_catalog.c b/drivers/gpu/drm/msm/adreno/a5xx_catalog.c
index b48a636d82370ec78e2869e9d5fa96c5c9f90a95..babd320f3b736f6b151887df02094c1a836b0750 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a5xx_catalog.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_catalog.c
@@ -7,6 +7,7 @@
  */
 
 #include "adreno_gpu.h"
+#include "a5xx_gpu.h"
 
 static const struct adreno_info a5xx_gpus[] = {
        {
@@ -21,7 +22,7 @@ static const struct adreno_info a5xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_TWO_PASS_USE_WFI |
                          ADRENO_QUIRK_LMLOADKILL_DISABLE,
-               .init = a5xx_gpu_init,
+               .funcs = &a5xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x05000600),
                .family = ADRENO_5XX,
@@ -38,7 +39,7 @@ static const struct adreno_info a5xx_gpus[] = {
                .inactive_period = 250,
                .quirks = ADRENO_QUIRK_TWO_PASS_USE_WFI |
                          ADRENO_QUIRK_LMLOADKILL_DISABLE,
-               .init = a5xx_gpu_init,
+               .funcs = &a5xx_gpu_funcs,
                .zapfw = "a506_zap.mdt",
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x05000800),
@@ -55,7 +56,7 @@ static const struct adreno_info a5xx_gpus[] = {
                 */
                .inactive_period = 250,
                .quirks = ADRENO_QUIRK_LMLOADKILL_DISABLE,
-               .init = a5xx_gpu_init,
+               .funcs = &a5xx_gpu_funcs,
                .zapfw = "a508_zap.mdt",
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x05000900),
@@ -72,7 +73,7 @@ static const struct adreno_info a5xx_gpus[] = {
                 */
                .inactive_period = 250,
                .quirks = ADRENO_QUIRK_LMLOADKILL_DISABLE,
-               .init = a5xx_gpu_init,
+               .funcs = &a5xx_gpu_funcs,
                /* Adreno 509 uses the same ZAP as 512 */
                .zapfw = "a512_zap.mdt",
        }, {
@@ -89,7 +90,7 @@ static const struct adreno_info a5xx_gpus[] = {
                 * the GDSC which appears to make it grumpy
                 */
                .inactive_period = 250,
-               .init = a5xx_gpu_init,
+               .funcs = &a5xx_gpu_funcs,
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x05010200),
                .family = ADRENO_5XX,
@@ -105,7 +106,7 @@ static const struct adreno_info a5xx_gpus[] = {
                 */
                .inactive_period = 250,
                .quirks = ADRENO_QUIRK_LMLOADKILL_DISABLE,
-               .init = a5xx_gpu_init,
+               .funcs = &a5xx_gpu_funcs,
                .zapfw = "a512_zap.mdt",
        }, {
                .chip_ids = ADRENO_CHIP_IDS(
@@ -127,7 +128,7 @@ static const struct adreno_info a5xx_gpus[] = {
                .inactive_period = 250,
                .quirks = ADRENO_QUIRK_TWO_PASS_USE_WFI |
                        ADRENO_QUIRK_FAULT_DETECT_MASK,
-               .init = a5xx_gpu_init,
+               .funcs = &a5xx_gpu_funcs,
                .zapfw = "a530_zap.mdt",
        }, {
                .chip_ids = ADRENO_CHIP_IDS(0x05040001),
@@ -145,7 +146,7 @@ static const struct adreno_info a5xx_gpus[] = {
                 */
                .inactive_period = 250,
                .quirks = ADRENO_QUIRK_LMLOADKILL_DISABLE,
-               .init = a5xx_gpu_init,
+               .funcs = &a5xx_gpu_funcs,
                .zapfw = "a540_zap.mdt",
        }
 };

diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
index 4a04dc43a8e6764a113d0ade3dee94bd4c0083af..56eaff2ee4e4b82b55530ac818c88f0d248a1942 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.c
@@ -1691,34 +1691,6 @@ static uint32_t a5xx_get_rptr(struct msm_gpu *gpu, struct msm_ringbuffer *ring)
        return ring->memptrs->rptr = gpu_read(gpu, REG_A5XX_CP_RB_RPTR);
 }
 
-static const struct adreno_gpu_funcs funcs = {
-       .base = {
-               .get_param = adreno_get_param,
-               .set_param = adreno_set_param,
-               .hw_init = a5xx_hw_init,
-               .ucode_load = a5xx_ucode_load,
-               .pm_suspend = a5xx_pm_suspend,
-               .pm_resume = a5xx_pm_resume,
-               .recover = a5xx_recover,
-               .submit = a5xx_submit,
-               .active_ring = a5xx_active_ring,
-               .irq = a5xx_irq,
-               .destroy = a5xx_destroy,
-#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
-               .show = a5xx_show,
-#endif
-#if defined(CONFIG_DEBUG_FS)
-               .debugfs_init = a5xx_debugfs_init,
-#endif
-               .gpu_busy = a5xx_gpu_busy,
-               .gpu_state_get = a5xx_gpu_state_get,
-               .gpu_state_put = a5xx_gpu_state_put,
-               .create_vm = adreno_create_vm,
-               .get_rptr = a5xx_get_rptr,
-       },
-       .get_timestamp = a5xx_get_timestamp,
-};
-
 static void check_speed_bin(struct device *dev)
 {
        struct nvmem_cell *cell;
@@ -1751,7 +1723,7 @@ static void check_speed_bin(struct device *dev)
        devm_pm_opp_set_supported_hw(dev, &val, 1);
 }
 
-struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)
+static struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)
 {
        struct msm_drm_private *priv = dev->dev_private;
        struct platform_device *pdev = priv->gpu_pdev;
@@ -1781,7 +1753,7 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)
        if (config->info->revn == 510)
                nr_rings = 1;
 
-       ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs, nr_rings);
+       ret = adreno_gpu_init(dev, pdev, adreno_gpu, config->info->funcs, nr_rings);
        if (ret) {
                a5xx_destroy(&(a5xx_gpu->base.base));
                return ERR_PTR(ret);
@@ -1806,3 +1778,32 @@ struct msm_gpu *a5xx_gpu_init(struct drm_device *dev)
 
        return gpu;
 }
+
+const struct adreno_gpu_funcs a5xx_gpu_funcs = {
+       .base = {
+               .get_param = adreno_get_param,
+               .set_param = adreno_set_param,
+               .hw_init = a5xx_hw_init,
+               .ucode_load = a5xx_ucode_load,
+               .pm_suspend = a5xx_pm_suspend,
+               .pm_resume = a5xx_pm_resume,
+               .recover = a5xx_recover,
+               .submit = a5xx_submit,
+               .active_ring = a5xx_active_ring,
+               .irq = a5xx_irq,
+               .destroy = a5xx_destroy,
+#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP)
+               .show = a5xx_show,
+#endif
+#if defined(CONFIG_DEBUG_FS)
+               .debugfs_init = a5xx_debugfs_init,
+#endif
+               .gpu_busy = a5xx_gpu_busy,
+               .gpu_state_get = a5xx_gpu_state_get,
+               .gpu_state_put = a5xx_gpu_state_put,
+               .create_vm = adreno_create_vm,
+               .get_rptr = a5xx_get_rptr,
+       },
+       .init = a5xx_gpu_init,
+       .get_timestamp = a5xx_get_timestamp,
+};

diff --git a/drivers/gpu/drm/msm/adreno/a5xx_gpu.h b/drivers/gpu/drm/msm/adreno/a5xx_gpu.h
index 9c0d701fe4b85baf6a34d33067e5e0f677d74692..407bb950d35026af0861d23d7fe9ce702ac35111 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a5xx_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/a5xx_gpu.h
@@ -133,6 +133,7 @@ struct a5xx_preempt_record {
  */
 #define A5XX_PREEMPT_COUNTER_SIZE (16 * 4)
 
+extern const struct adreno_gpu_funcs a5xx_gpu_funcs;
 
 int a5xx_power_init(struct msm_gpu *gpu);
 void a5xx_gpmu_ucode_init(struct msm_gpu *gpu);

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
index 5db01fa2ed441d3fc33b27f7c9868c591e08604e..70433965c30309e5c35d1ebb9139183579c0d4ff 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c
@@ -683,7 +683,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .gmem = (SZ_128K + SZ_4K),
                .quirks = ADRENO_QUIRK_4GB_VA,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gmuwrapper_funcs,
                .zapfw = "a610_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a612_hwcg,
@@ -714,7 +714,7 @@ static const struct adreno_info a6xx_gpus[] = {
                },
                .gmem = (SZ_128K + SZ_4K),
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gmuwrapper_funcs,
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a612_hwcg,
                        .protect = &a630_protect,
@@ -732,7 +732,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .gmem = SZ_512K,
                .quirks = ADRENO_QUIRK_4GB_VA,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a615_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a615_hwcg,
@@ -763,7 +763,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_4GB_VA,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a615_zap.mbn",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a615_hwcg,
@@ -790,7 +790,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_4GB_VA,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .a6xx = &(const struct a6xx_info) {
                        .protect = &a630_protect,
                        .gmu_cgc_mode = 0x00000222,
@@ -813,7 +813,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .gmem = SZ_512K,
                .quirks = ADRENO_QUIRK_4GB_VA,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a615_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a615_hwcg,
@@ -838,7 +838,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .gmem = SZ_512K,
                .quirks = ADRENO_QUIRK_4GB_VA,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a615_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a615_hwcg,
@@ -863,7 +863,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_4GB_VA,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a615_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a615_hwcg,
@@ -889,7 +889,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_HAS_HW_APRIV,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a620_zap.mbn",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a620_hwcg,
@@ -912,7 +912,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                        ADRENO_QUIRK_HAS_HW_APRIV,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a690_hwcg,
                        .protect = &a650_protect,
@@ -949,7 +949,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_4GB_VA,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a630_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a630_hwcg,
@@ -969,7 +969,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_4GB_VA,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a640_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a640_hwcg,
@@ -993,7 +993,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                        ADRENO_QUIRK_HAS_HW_APRIV,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a650_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a650_hwcg,
@@ -1019,7 +1019,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                        ADRENO_QUIRK_HAS_HW_APRIV,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a660_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a660_hwcg,
@@ -1038,7 +1038,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                        ADRENO_QUIRK_HAS_HW_APRIV,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a690_hwcg,
                        .protect = &a660_protect,
@@ -1061,7 +1061,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                        ADRENO_QUIRK_HAS_HW_APRIV,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a660_zap.mbn",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a660_hwcg,
@@ -1088,7 +1088,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_4GB_VA,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a640_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a640_hwcg,
@@ -1107,7 +1107,7 @@ static const struct adreno_info a6xx_gpus[] = {
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                        ADRENO_QUIRK_HAS_HW_APRIV,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gpu_funcs,
                .zapfw = "a690_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a690_hwcg,
@@ -1442,7 +1442,7 @@ static const struct adreno_info a7xx_gpus[] = {
                .gmem = SZ_128K,
                .inactive_period = DRM_MSM_INACTIVE_PERIOD,
                .quirks = ADRENO_QUIRK_HAS_HW_APRIV,
-               .init = a6xx_gpu_init,
+               .funcs = &a6xx_gmuwrapper_funcs,
                .zapfw = "a702_zap.mbn",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a702_hwcg,
@@ -1468,7 +1468,7 @@ static const struct adreno_info a7xx_gpus[] = {
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_HAS_HW_APRIV |
                          ADRENO_QUIRK_PREEMPTION,
-               .init = a6xx_gpu_init,
+               .funcs = &a7xx_gpu_funcs,
                .zapfw = "a730_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a730_hwcg,
@@ -1489,7 +1489,7 @@ static const struct adreno_info a7xx_gpus[] = {
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_HAS_HW_APRIV |
                          ADRENO_QUIRK_PREEMPTION,
-               .init = a6xx_gpu_init,
+               .funcs = &a7xx_gpu_funcs,
                .zapfw = "a740_zap.mdt",
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a740_hwcg,
@@ -1523,7 +1523,7 @@ static const struct adreno_info a7xx_gpus[] = {
                          ADRENO_QUIRK_HAS_HW_APRIV |
                          ADRENO_QUIRK_PREEMPTION |
                          ADRENO_QUIRK_IFPC,
-               .init = a6xx_gpu_init,
+               .funcs = &a7xx_gpu_funcs,
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a740_hwcg,
                        .protect = &a730_protect,
@@ -1564,7 +1564,7 @@ static const struct adreno_info a7xx_gpus[] = {
                          ADRENO_QUIRK_HAS_HW_APRIV |
                          ADRENO_QUIRK_PREEMPTION |
                          ADRENO_QUIRK_IFPC,
-               .init = a6xx_gpu_init,
+               .funcs = &a7xx_gpu_funcs,
                .zapfw = "gen70900_zap.mbn",
                .a6xx = &(const struct a6xx_info) {
                        .protect = &a730_protect,
@@ -1597,7 +1597,7 @@ static const struct adreno_info a7xx_gpus[] = {
                .quirks = ADRENO_QUIRK_HAS_CACHED_COHERENT |
                          ADRENO_QUIRK_HAS_HW_APRIV |
                          ADRENO_QUIRK_PREEMPTION,
-               .init = a6xx_gpu_init,
+               .funcs = &a7xx_gpu_funcs,
                .a6xx = &(const struct a6xx_info) {
                        .hwcg = a740_hwcg,
                        .protect = &a730_protect,

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index c6b2fdb86c17b1f4d73e08910ee15d768fc6863d..ba95b29855a3f8bd157b0926ebe3c34501ffaab6 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -2555,100 +2555,7 @@ static int a6xx_set_supported_hw(struct device *dev, const struct adreno_info *i
        return 0;
 }
 
-static const struct adreno_gpu_funcs funcs = {
-       .base = {
-               .get_param = adreno_get_param,
-               .set_param = adreno_set_param,
-               .hw_init = a6xx_hw_init,
-               .ucode_load = a6xx_ucode_load,
-               .pm_suspend = a6xx_gmu_pm_suspend,
-               .pm_resume = a6xx_gmu_pm_resume,
-               .recover = a6xx_recover,
-               .submit = a6xx_submit,
-               .active_ring = a6xx_active_ring,
-               .irq = a6xx_irq,
-               .destroy = a6xx_destroy,
-#if defined(CONFIG_DRM_MSM_GPU_STATE)
-               .show = a6xx_show,
-#endif
-               .gpu_busy = a6xx_gpu_busy,
-               .gpu_get_freq = a6xx_gmu_get_freq,
-               .gpu_set_freq = a6xx_gpu_set_freq,
-#if defined(CONFIG_DRM_MSM_GPU_STATE)
-               .gpu_state_get = a6xx_gpu_state_get,
-               .gpu_state_put = a6xx_gpu_state_put,
-#endif
-               .create_vm = a6xx_create_vm,
-               .create_private_vm = a6xx_create_private_vm,
-               .get_rptr = a6xx_get_rptr,
-               .progress = a6xx_progress,
-               .sysprof_setup = a6xx_gmu_sysprof_setup,
-       },
-       .get_timestamp = a6xx_gmu_get_timestamp,
-};
-
-static const struct adreno_gpu_funcs funcs_gmuwrapper = {
-       .base = {
-               .get_param = adreno_get_param,
-               .set_param = adreno_set_param,
-               .hw_init = a6xx_hw_init,
-               .ucode_load = a6xx_ucode_load,
-               .pm_suspend = a6xx_pm_suspend,
-               .pm_resume = a6xx_pm_resume,
-               .recover = a6xx_recover,
-               .submit = a6xx_submit,
-               .active_ring = a6xx_active_ring,
-               .irq = a6xx_irq,
-               .destroy = a6xx_destroy,
-#if defined(CONFIG_DRM_MSM_GPU_STATE)
-               .show = a6xx_show,
-#endif
-               .gpu_busy = a6xx_gpu_busy,
-#if defined(CONFIG_DRM_MSM_GPU_STATE)
-               .gpu_state_get = a6xx_gpu_state_get,
-               .gpu_state_put = a6xx_gpu_state_put,
-#endif
-               .create_vm = a6xx_create_vm,
-               .create_private_vm = a6xx_create_private_vm,
-               .get_rptr = a6xx_get_rptr,
-               .progress = a6xx_progress,
-       },
-       .get_timestamp = a6xx_get_timestamp,
-};
-
-static const struct adreno_gpu_funcs funcs_a7xx = {
-       .base = {
-               .get_param = adreno_get_param,
-               .set_param = adreno_set_param,
-               .hw_init = a6xx_hw_init,
-               .ucode_load = a6xx_ucode_load,
-               .pm_suspend = a6xx_gmu_pm_suspend,
-               .pm_resume = a6xx_gmu_pm_resume,
-               .recover = a6xx_recover,
-               .submit = a7xx_submit,
-               .active_ring = a6xx_active_ring,
-               .irq = a6xx_irq,
-               .destroy = a6xx_destroy,
-#if defined(CONFIG_DRM_MSM_GPU_STATE)
-               .show = a6xx_show,
-#endif
-               .gpu_busy = a6xx_gpu_busy,
-               .gpu_get_freq = a6xx_gmu_get_freq,
-               .gpu_set_freq = a6xx_gpu_set_freq,
-#if defined(CONFIG_DRM_MSM_GPU_STATE)
-               .gpu_state_get = a6xx_gpu_state_get,
-               .gpu_state_put = a6xx_gpu_state_put,
-#endif
-               .create_vm = a6xx_create_vm,
-               .create_private_vm = a6xx_create_private_vm,
-               .get_rptr = a6xx_get_rptr,
-               .progress = a6xx_progress,
-               .sysprof_setup = a6xx_gmu_sysprof_setup,
-       },
-       .get_timestamp = a6xx_gmu_get_timestamp,
-};
-
-struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
+static struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
 {
        struct msm_drm_private *priv = dev->dev_private;
        struct platform_device *pdev = priv->gpu_pdev;
@@ -2659,7 +2566,7 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
        struct msm_gpu *gpu;
        extern int enable_preemption;
        bool is_a7xx;
-       int ret;
+       int ret, nr_rings = 1;
 
        a6xx_gpu = kzalloc(sizeof(*a6xx_gpu), GFP_KERNEL);
        if (!a6xx_gpu)
@@ -2698,14 +2605,9 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
 
        if ((enable_preemption == 1) || (enable_preemption == -1 &&
            (config->info->quirks & ADRENO_QUIRK_PREEMPTION)))
-               ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs_a7xx, 4);
-       else if (is_a7xx)
-               ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs_a7xx, 1);
-       else if (adreno_has_gmu_wrapper(adreno_gpu) ||
-                of_device_is_compatible(node, "qcom,adreno-rgmu"))
-               ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs_gmuwrapper, 1);
-       else
-               ret = adreno_gpu_init(dev, pdev, adreno_gpu, &funcs, 1);
+               nr_rings = 4;
+
+       ret = adreno_gpu_init(dev, pdev, adreno_gpu, config->info->funcs, nr_rings);
        if (ret) {
                a6xx_destroy(&(a6xx_gpu->base.base));
                return ERR_PTR(ret);
@@ -2752,3 +2654,97 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
 
        return gpu;
 }
+
+const struct adreno_gpu_funcs a6xx_gpu_funcs = {
+       .base = {
+               .get_param = adreno_get_param,
+               .set_param = adreno_set_param,
+               .hw_init = a6xx_hw_init,
+               .ucode_load = a6xx_ucode_load,
+               .pm_suspend = a6xx_gmu_pm_suspend,
+               .pm_resume = a6xx_gmu_pm_resume,
+               .recover = a6xx_recover,
+               .submit = a6xx_submit,
+               .active_ring = a6xx_active_ring,
+               .irq = a6xx_irq,
+               .destroy = a6xx_destroy,
+#if defined(CONFIG_DRM_MSM_GPU_STATE)
+               .show = a6xx_show,
+#endif
+               .gpu_busy = a6xx_gpu_busy,
+               .gpu_get_freq = a6xx_gmu_get_freq,
+               .gpu_set_freq = a6xx_gpu_set_freq,
+#if defined(CONFIG_DRM_MSM_GPU_STATE)
+               .gpu_state_get = a6xx_gpu_state_get,
+               .gpu_state_put = a6xx_gpu_state_put,
+#endif
+               .create_vm = a6xx_create_vm,
+               .create_private_vm = a6xx_create_private_vm,
+               .get_rptr = a6xx_get_rptr,
+               .progress = a6xx_progress,
+       },
+       .init = a6xx_gpu_init,
+       .get_timestamp = a6xx_gmu_get_timestamp,
+};
+
+const struct adreno_gpu_funcs a6xx_gmuwrapper_funcs = {
+       .base = {
+               .get_param = adreno_get_param,
+               .set_param = adreno_set_param,
+               .hw_init = a6xx_hw_init,
+               .ucode_load = a6xx_ucode_load,
+               .pm_suspend = a6xx_pm_suspend,
+               .pm_resume = a6xx_pm_resume,
+               .recover = a6xx_recover,
+               .submit = a6xx_submit,
+               .active_ring = a6xx_active_ring,
+               .irq = a6xx_irq,
+               .destroy = a6xx_destroy,
+#if defined(CONFIG_DRM_MSM_GPU_STATE)
+               .show = a6xx_show,
+#endif
+               .gpu_busy = a6xx_gpu_busy,
+#if defined(CONFIG_DRM_MSM_GPU_STATE)
+               .gpu_state_get = a6xx_gpu_state_get,
+               .gpu_state_put = a6xx_gpu_state_put,
+#endif
+               .create_vm = a6xx_create_vm,
+               .create_private_vm = a6xx_create_private_vm,
+               .get_rptr = a6xx_get_rptr,
+               .progress = a6xx_progress,
+       },
+       .init = a6xx_gpu_init,
+       .get_timestamp = a6xx_get_timestamp,
+};
+
+const struct adreno_gpu_funcs a7xx_gpu_funcs = {
+       .base = {
+               .get_param = adreno_get_param,
+               .set_param = adreno_set_param,
+               .hw_init = a6xx_hw_init,
+               .ucode_load = a6xx_ucode_load,
+               .pm_suspend = a6xx_gmu_pm_suspend,
+               .pm_resume = a6xx_gmu_pm_resume,
+               .recover = a6xx_recover,
+               .submit = a7xx_submit,
+               .active_ring = a6xx_active_ring,
+               .irq = a6xx_irq,
+               .destroy = a6xx_destroy,
+#if defined(CONFIG_DRM_MSM_GPU_STATE)
+               .show = a6xx_show,
+#endif
+               .gpu_busy = a6xx_gpu_busy,
+               .gpu_get_freq = a6xx_gmu_get_freq,
+               .gpu_set_freq = a6xx_gpu_set_freq,
+#if defined(CONFIG_DRM_MSM_GPU_STATE)
+               .gpu_state_get = a6xx_gpu_state_get,
+               .gpu_state_put = a6xx_gpu_state_put,
+#endif
+               .create_vm = a6xx_create_vm,
+               .create_private_vm = a6xx_create_private_vm,
+               .get_rptr = a6xx_get_rptr,
+               .progress = a6xx_progress,
+       },
+       .init = a6xx_gpu_init,
+       .get_timestamp = a6xx_gmu_get_timestamp,
+};

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
index 0b17d36c36a9567e6afa4269ae7783ed3578e40e..ef66e1eb91528b5d070658bf104a24834b2b3816 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
@@ -216,6 +216,10 @@ struct a7xx_cp_smmu_info {
 #define A6XX_PROTECT_RDONLY(_reg, _len) \
        ((((_len) & 0x3FFF) << 18) | ((_reg) & 0x3FFFF))
 
+extern const struct adreno_gpu_funcs a6xx_gpu_funcs;
+extern const struct adreno_gpu_funcs a6xx_gmuwrapper_funcs;
+extern const struct adreno_gpu_funcs a7xx_gpu_funcs;
+
 static inline bool a6xx_has_gbif(struct adreno_gpu *gpu)
 {
        if(adreno_is_a630(gpu))

diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c
index 28f744f3caf7c59412aab06f912cd09a01e185ea..cb4113612b824ac49ef452bbf47ebeda6d188366 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/adreno_device.c
+++ b/drivers/gpu/drm/msm/adreno/adreno_device.c
@@ -235,7 +235,7 @@ static int adreno_bind(struct device *dev, struct device *master, void *data)
        priv->has_cached_coherent =
                !!(info->quirks & ADRENO_QUIRK_HAS_CACHED_COHERENT);
 
-       gpu = info->init(drm);
+       gpu = info->funcs->init(drm);
        if (IS_ERR(gpu)) {
                dev_warn(drm->dev, "failed to load adreno gpu\n");
                return PTR_ERR(gpu);

diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
index 4acb03dcbc609b72dfb95d40d5d247e9ca07bfb2..335acd5feb82c3e99a8e037ce3e3d1df012329ec 100644 (file)
--- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
@@ -71,8 +71,11 @@ enum adreno_family {
        (((_c) >> 8)  & 0xff), \
        ((_c) & 0xff)
 
+struct adreno_gpu;
+
 struct adreno_gpu_funcs {
        struct msm_gpu_funcs base;
+       struct msm_gpu *(*init)(struct drm_device *dev);
        int (*get_timestamp)(struct msm_gpu *gpu, uint64_t *value);
 };
 
@@ -101,7 +104,7 @@ struct adreno_info {
        const char *fw[ADRENO_FW_MAX];
        uint32_t gmem;
        u64 quirks;
-       struct msm_gpu *(*init)(struct drm_device *dev);
+       const struct adreno_gpu_funcs *funcs;
        const char *zapfw;
        u32 inactive_period;
        union {
@@ -685,12 +688,6 @@ OUT_PKT7(struct msm_ringbuffer *ring, uint8_t opcode, uint16_t cnt)
        OUT_RING(ring, PKT7(opcode, cnt));
 }
 
-struct msm_gpu *a2xx_gpu_init(struct drm_device *dev);
-struct msm_gpu *a3xx_gpu_init(struct drm_device *dev);
-struct msm_gpu *a4xx_gpu_init(struct drm_device *dev);
-struct msm_gpu *a5xx_gpu_init(struct drm_device *dev);
-struct msm_gpu *a6xx_gpu_init(struct drm_device *dev);
-
 static inline uint32_t get_wptr(struct msm_ringbuffer *ring)
 {
        return (ring->cur - ring->start) % (MSM_GPU_RINGBUFFER_SZ >> 2);