]> Gentwo Git Trees - linux/.git/commitdiff
tracing: Remove unused variable in tracing_trace_options_show()
authorSteven Rostedt <rostedt@goodmis.org>
Mon, 17 Nov 2025 17:06:37 +0000 (12:06 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 26 Nov 2025 20:13:28 +0000 (15:13 -0500)
The flags and opts used in tracing_trace_options_show() now come directly
from the trace array "current_trace_flags" and not the current_trace. The
variable "trace" was still being assigned to tr->current_trace but never
used. This caused a warning in clang.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20251117120637.43ef995d@gandalf.local.home
Reported-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Tested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Closes: https://lore.kernel.org/all/aRtHWXzYa8ijUIDa@black.igk.intel.com/
Fixes: 428add559b692 ("tracing: Have tracer option be instance specific")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace.c

index 8ae95800592d64ffc69dbf1fe42c7fb35b83ad8a..59cd4ed8af6dec3b2d16aa020dbcda3ceb0b9a13 100644 (file)
@@ -5167,7 +5167,6 @@ static int tracing_trace_options_show(struct seq_file *m, void *v)
        struct tracer_opt *trace_opts;
        struct trace_array *tr = m->private;
        struct tracer_flags *flags;
-       struct tracer *trace;
        u32 tracer_flags;
        int i;
 
@@ -5184,8 +5183,6 @@ static int tracing_trace_options_show(struct seq_file *m, void *v)
        if (!flags || !flags->opts)
                return 0;
 
-       trace = tr->current_trace;
-
        tracer_flags = flags->val;
        trace_opts = flags->opts;